Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test_multiple_disks::test_kill_while_insert a little #8135

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Fixed test_multiple_disks::test_kill_while_insert a little #8135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d162c
Fixed `test_multiple_disks::test_kill_while_insert` a little.
excitoon Dec 11, 2019
1ca9cef
Fixed typo.
excitoon Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions dbms/tests/integration/test_multiple_disks/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,8 +1069,6 @@ def test_kill_while_insert(start_cluster):
try:
name = "test_kill_while_insert"

node1.query("DROP TABLE IF EXISTS {name}".format(name=name))

node1.query("""
CREATE TABLE {name} (
s String
Expand Down Expand Up @@ -1107,7 +1105,10 @@ def test_kill_while_insert(start_cluster):
assert node1.query("SELECT count() FROM {name}".format(name=name)).splitlines() == ["10"]

finally:
"""Don't drop table afterwards to not shadow assertion."""
try:
node1.query("DROP TABLE IF EXISTS {name}".format(name=name))
except:
"""ClickHouse may be inactive at this moment and we don't want to mask a meaningful exception."""


def test_move_while_merge(start_cluster):
Expand Down