Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid failure of tests under UBSan for randomPrintableASCII function #8480

Merged
merged 2 commits into from Dec 31, 2019
Merged

Avoid failure of tests under UBSan for randomPrintableASCII function #8480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53fbe0b
Avoid UBSan report
alexey-milovidov Dec 30, 2019
445b494
Added test
alexey-milovidov Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions dbms/src/Columns/ColumnVector.h
View file
Open in desktop
Expand Up @@ -212,19 +212,21 @@ class ColumnVector final : public COWHelper<ColumnVectorHelper, ColumnVector<T>>
Float64 getFloat64(size_t n) const override;
Float32 getFloat32(size_t n) const override;

UInt64 getUInt(size_t n) const override
/// Out of range conversion is permitted.
UInt64 NO_SANITIZE_UNDEFINED getUInt(size_t n) const override
{
return UInt64(data[n]);
}

bool getBool(size_t n) const override
/// Out of range conversion is permitted.
Int64 NO_SANITIZE_UNDEFINED getInt(size_t n) const override
{
return bool(data[n]);
return Int64(data[n]);
}

Int64 getInt(size_t n) const override
bool getBool(size_t n) const override
{
return Int64(data[n]);
return bool(data[n]);
}

void insert(const Field & x) override
Expand Down
1 change: 1 addition & 0 deletions dbms/tests/queries/0_stateless/01054_random_printable_ascii_ubsan.reference
View file
Open in desktop
@@ -0,0 +1 @@
Ok
14 changes: 14 additions & 0 deletions dbms/tests/queries/0_stateless/01054_random_printable_ascii_ubsan.sh
View file
Open in desktop
@@ -0,0 +1,14 @@
#!/usr/bin/env bash

CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
. $CURDIR/../shell_config.sh

# Implementation specific behaviour on overflow. We may return error or produce empty string.
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(nan);" >/dev/null 2>&1 ||:
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(inf);" >/dev/null 2>&1 ||:
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(-inf);" >/dev/null 2>&1 ||:
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(1e300);" >/dev/null 2>&1 ||:
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(-123.456);" >/dev/null 2>&1 ||:
${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(-1);" >/dev/null 2>&1 ||:

${CLICKHOUSE_CLIENT} --query="SELECT randomPrintableASCII(0), 'Ok';"