Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong counting of DictCacheKeysRequestedFound metric #9411

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Wrong counting of DictCacheKeysRequestedFound metric #9411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d776e91
first
nikitamikhaylov Feb 27, 2020
067eb57
bump test
nikitamikhaylov Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbms/src/Dictionaries/ComplexKeyCacheDictionary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ class ComplexKeyCacheDictionary final : public IDictionaryBase
on_key_not_found(key, cell_idx);
}

ProfileEvents::increment(ProfileEvents::DictCacheKeysRequestedMiss, found_num);
ProfileEvents::increment(ProfileEvents::DictCacheKeysRequestedFound, found_num);
ProfileEvents::increment(ProfileEvents::DictCacheKeysRequestedMiss, not_found_num);
}

Expand Down