Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scalar optimization in ALTER mutations #9904

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix scalar optimization in ALTER mutations #9904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions dbms/src/Interpreters/MutationsInterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,10 @@ ASTPtr MutationsInterpreter::prepareInterpreterSelectQuery(std::vector<Stage> &
all_asts->children.push_back(std::make_shared<ASTIdentifier>(column));

auto syntax_result = SyntaxAnalyzer(context).analyze(all_asts, all_columns);
if (context.hasQueryContext())
for (const auto & it : syntax_result->getScalars())
context.getQueryContext().addScalar(it.first, it.second);

stage.analyzer = std::make_unique<ExpressionAnalyzer>(all_asts, syntax_result, context);

ExpressionActionsChain & actions_chain = stage.expressions_chain;
Expand Down
2 changes: 1 addition & 1 deletion dbms/src/Interpreters/MutationsInterpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class MutationsInterpreter

StoragePtr storage;
MutationCommands commands;
const Context & context;
Context context;
bool can_execute;

ASTPtr mutation_ast;
Expand Down
Empty file added dbms/tests/queries/0_stateless/01220_scalar_optimization_in_alter.reference
View file
Open in desktop
Empty file.
9 changes: 9 additions & 0 deletions dbms/tests/queries/0_stateless/01220_scalar_optimization_in_alter.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
drop table if exists cdp_segments;
drop table if exists cdp_customers;

create table cdp_segments (seg_id String, mid_seqs AggregateFunction(groupBitmap, UInt32)) engine=ReplacingMergeTree() order by (seg_id);
create table cdp_customers (mid String, mid_seq UInt32) engine=ReplacingMergeTree() order by (mid_seq);
alter table cdp_segments update mid_seqs = bitmapOr(mid_seqs, (select groupBitmapState(mid_seq) from cdp_customers where mid in ('6bf3c2ee-2b33-3030-9dc2-25c6c618d141'))) where seg_id = '1234567890';

drop table cdp_segments;
drop table cdp_customers;