Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-conformance in RESTCONF RPC request. #30

Closed
vdv18 opened this issue Jun 15, 2018 · 1 comment
Closed

Non-conformance in RESTCONF RPC request. #30

vdv18 opened this issue Jun 15, 2018 · 1 comment

Comments

@vdv18
Copy link

vdv18 commented Jun 15, 2018

Expected only one URL per RPC.

POST /restconf/operations/example-ops:reboot HTTP/1.1

But currently I can do it like this without errors:

POST /restconf/operations/abc:reboot HTTP/1.1
POST /restconf/operations/example:reboot HTTP/1.1

Links:
rfc8040#section-3.6
rfc8040#section-3.6.1

olofhagsand added a commit that referenced this issue Jun 20, 2018
@dmitryvvv
Copy link

dmitryvvv commented Jun 26, 2018

Hi Olof.

Thank you for resolving this issue.

Some notes for this issue:

According rfc8040#section-3.6 we may use request an operation such:

POST /restconf/operations/<module_name>:<rpc_procedure> HTTP/1.1

But current algorithm supports uasage only:

POST /restconf/operations/<module_prefix>:<rpc_procedure> HTTP/1.1

this piece of code check only Y_PREFIX nodes:

lib/src/clixon_yang.c
+ if ((yprefix = yang_find((yang_node*)ymod, Y_PREFIX, NULL)) != NULL &&
+ strcmp(yprefix->ys_argument, prefix) != 0){
+ clicon_err(OE_YANG, 0, "Module with id:%s:%s not found", prefix,id);
+ goto done;
+ }

Thanks,
Dmitry.

olofhagsand added a commit that referenced this issue Jul 13, 2018
…odule name.

  * Proper specification for an operation is POST /restconf/operations/<module_name>:<rpc_procedure> HTTP/1.1
  * See #31, #32 and #30
  * Thanks David Cornejo and Dmitry Vakhrushev of Netgate for pointing this out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants