Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make specification of an operation compliant with RFC8040 section 3.6 #32

Closed
wants to merge 1 commit into from
Closed

Conversation

dcornejo
Copy link
Contributor

@dcornejo dcornejo commented Jul 3, 2018

RFC 8030 section 3.6 indicates that an operation is identified by both module name and operation ID. The latest code used the prefix rather than the module name, which I believe is contrary to the RFC. This pull request removes the (possibly) erroneous check of the prefix and changes the code to require a module name match to resolve #31

an operation is specified by the <module name>:<operation id>. check
to make sure that module name and operation ID both match the YANG
spec.
olofhagsand added a commit that referenced this pull request Jul 13, 2018
…odule name.

  * Proper specification for an operation is POST /restconf/operations/<module_name>:<rpc_procedure> HTTP/1.1
  * See #31, #32 and #30
  * Thanks David Cornejo and Dmitry Vakhrushev of Netgate for pointing this out
@olofhagsand
Copy link
Member

I needed to make a larger and more specific change for restconf operations GET and PUT, see patch above.
Thanks for detecting this major divergence from RFC 8040!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants