Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not check if the rule is valid #6

Closed
sthaha opened this issue Aug 26, 2014 · 2 comments
Closed

does not check if the rule is valid #6

sthaha opened this issue Aug 26, 2014 · 2 comments

Comments

@sthaha
Copy link

sthaha commented Aug 26, 2014

112: if (validator[rule](arg) === false) {
assumes the rule is present. notEmpty was valid until commit 5d1ae480dc59e8c6197eb4b05f0eda1f5def027a in validator.js. Perhaps there should be a validation if the rule itself is valid and print appropriate error.

@cliffano
Copy link
Owner

Agreed, will add rule check and log message accordingly.

@cliffano
Copy link
Owner

This is done in 0.0.10. Dependant modules should now get a proper error message when rule doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants