-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A streaming API of job console output #10
Conversation
Since we're returning a readable stream, callers can just listen to the end event instead of passing in a callback function.
Documentation is always an afterthought.
I've just setup Travis-CI and it seems that I just broke the build. Problem is, I can't run tests locally. Here are my steps:
Any ideas how I can run tests before pushing? |
What's the output of node --version && bob --version ? The unit tests (in test directory) pretty much mock the console output, so you'll need to look at how you can do the same thing. Once you get the build passing, do you mind opening a new pull request with a single commit for these changes? That would be easier to read. |
I was running nodejs v0.8.22 and bob 0.5.16. I just reinstalled bob 0.5.17 and it still fails. But I also realized that I've got a long abandoned incomplete And yes, it's totally okay for me to squash all commits into a single one. Now I'd go fix those test failures. |
Cool. I've also just added 0.10 and 0.11 to Travis CI run, to make sure everything passes. |
I've decided to just port all existing tests of |
Closing this one, replaced by #11 |
Hi,
I'm about to implement a simple continuous deployment dashboard integrating with Jenkins and I just stumbled upon nestor. A readable stream would be easier for me to implement a stream -> websocket proxy for browser. Luckily the current implementation is fairly complete and all I have to do is a little refactoring to get this far.
However, this pull request is by no means complete:
Feel free to tell me what more should I do to get this merged.