New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Coolrunner-II support #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All DFFs map to either FDCP (matches Xilinx) or a custom FDCP_N (negative-edge triggered)
These cannot be inferred yet, but add them to cells_sim.v for now
cc @azonenberg |
run(stringf("hierarchy -check %s", help_mode ? "-top <top>" : top_opt.c_str())); | ||
} | ||
|
||
if (flatten && check_label("flatten", "(unless -noflatten)")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the order of the two conditions:
if (check_label("flatten", "(unless -noflatten)") && flatten)
This way flatten
is still a valid label even if the -noflatten
option is used.
(Yes, I know that this is borderline nitpicking. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PAR functionality isn't done yet, but I wanted to create this initial PR to see if I did it right.