Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Coolrunner-II support #352

Merged
merged 9 commits into from Jul 3, 2017
Merged

Conversation

ArcaneNibble
Copy link
Contributor

The PAR functionality isn't done yet, but I wanted to create this initial PR to see if I did it right.

@ArcaneNibble
Copy link
Contributor Author

cc @azonenberg

@cliffordwolf cliffordwolf self-assigned this Jun 27, 2017
run(stringf("hierarchy -check %s", help_mode ? "-top <top>" : top_opt.c_str()));
}

if (flatten && check_label("flatten", "(unless -noflatten)"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the order of the two conditions:

if (check_label("flatten", "(unless -noflatten)") && flatten)

This way flatten is still a valid label even if the -noflatten option is used.

(Yes, I know that this is borderline nitpicking. :)

@cliffordwolf cliffordwolf merged commit 6afee02 into YosysHQ:master Jul 3, 2017
@cliffordwolf
Copy link
Collaborator

Merged with minor changes. See 5c1c126 and 621787a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants