Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change msat to sat #65

Merged
merged 1 commit into from
Aug 1, 2022
Merged

change msat to sat #65

merged 1 commit into from
Aug 1, 2022

Conversation

gautamjajoo
Copy link
Collaborator

Reverts Satoshi size to satoshi and removes msatoshi

vincenzopalazzo
vincenzopalazzo requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still same problem of before!

The JSX component need to contains only the logic for the UI, and these function are required in all the place where we need to decode an invoice or take some msat information.

components/tableNodes/NodeTable.component.tsx Outdated Show resolved Hide resolved
vincenzopalazzo
vincenzopalazzo previously approved these changes Aug 1, 2022
View reviewed changes
@vincenzopalazzo
Copy link
Member

Squash commit and we are good

@vincenzopalazzo vincenzopalazzo merged commit a01643b into clightning4j:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gautamjajoo @vincenzopalazzo