Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

[TurbConv] Many improvements in Grids / StateVecs #212

Merged
merged 1 commit into from
May 20, 2019
Merged

[TurbConv] Many improvements in Grids / StateVecs #212

merged 1 commit into from
May 20, 2019

Conversation

charleskawczynski
Copy link
Member

This PR:

  • Fixes 1st order gradient operators and their tests

  • Adds documentation to boundary conditions

  • Adds new grid operators

  • Adds @inbounds to some loops

  • Improves / changes defaults in StateVec print / export

  • Adds Neumann BC tests to documentation

fxgiraldo added a commit to fxgiraldo/CLIMA that referenced this pull request May 7, 2019
@fxgiraldo
Fixed all suggestions for PR CliMA#212 as suggested by jkozdon and si…
2ccf697 
…monbyrne
@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 14, 2019
@bors
Try #212:
cb2af58
@bors
Copy link
Contributor

bors bot commented May 14, 2019

try

Build succeeded

@charleskawczynski @simonbyrne
[TurbConv] Many fixes
d7c55c6 
This PR:

 - Fixes 1st order gradient operators and their tests

 - Adds documentation to boundary conditions

 - Improves / changes defaults in `StateVec` print / export

 - Adds Neumann BC tests to documentation
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #212 into master will increase coverage by 2.74%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage      90%   92.74%   +2.74%     
==========================================
  Files          30       59      +29     
  Lines        2220     3623    +1403     
==========================================
+ Hits         1998     3360    +1362     
- Misses        222      263      +41
Impacted Files Coverage Δ
...enceConvection/src/StateVecs/BoundaryConditions.jl 100% <ø> (ø)
...ns/TurbulenceConvection/src/StateVecs/StateVecs.jl 100% <100%> (ø)
...rameterizations/TurbulenceConvection/test/Grids.jl 100% <100%> (ø)
...ns/TurbulenceConvection/src/Grids/GridOperators.jl 57.14% <40%> (ø)
...urbulenceConvection/src/StateVecs/StateVecFuncs.jl 75.94% <85.71%> (ø)
src/Arrays/MPIStateArrays.jl 75.7% <0%> (-2.61%) ⬇️
src/DGmethods/NumericalFluxes.jl 100% <0%> (ø) ⬆️
...c/DGmethods/DGBalanceLawDiscretizations_kernels.jl 100% <0%> (ø) ⬆️
...tions/TurbulenceConvection/TurbulenceConvection.jl
...rbulenceConvection/StateVecs/BoundaryConditions.jl
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c4427...d7c55c6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #212 into master will increase coverage by 2.74%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage      90%   92.74%   +2.74%     
==========================================
  Files          30       59      +29     
  Lines        2220     3623    +1403     
==========================================
+ Hits         1998     3360    +1362     
- Misses        222      263      +41
Impacted Files Coverage Δ
...enceConvection/src/StateVecs/BoundaryConditions.jl 100% <ø> (ø)
...ns/TurbulenceConvection/src/StateVecs/StateVecs.jl 100% <100%> (ø)
...rameterizations/TurbulenceConvection/test/Grids.jl 100% <100%> (ø)
...ns/TurbulenceConvection/src/Grids/GridOperators.jl 57.14% <40%> (ø)
...urbulenceConvection/src/StateVecs/StateVecFuncs.jl 75.94% <85.71%> (ø)
src/Arrays/MPIStateArrays.jl 75.7% <0%> (-2.61%) ⬇️
src/DGmethods/NumericalFluxes.jl 100% <0%> (ø) ⬆️
...c/DGmethods/DGBalanceLawDiscretizations_kernels.jl 100% <0%> (ø) ⬆️
...tions/TurbulenceConvection/TurbulenceConvection.jl
...rbulenceConvection/StateVecs/BoundaryConditions.jl
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c4427...d7c55c6. Read the comment docs.

@simonbyrne
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 20, 2019
@bors @charleskawczynski
Merge #212
8e821f7 
212: [TurbConv] Many improvements in Grids / StateVecs r=simonbyrne a=charleskawczynski

This PR:

 - Fixes 1st order gradient operators and their tests

 - Adds documentation to boundary conditions

 - Adds new grid operators

 - Adds @inbounds to some loops

 - Improves / changes defaults in `StateVec` print / export

 - Adds Neumann BC tests to documentation

Co-authored-by: Charles_Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 20, 2019

Build succeeded

@bors bors bot merged commit d7c55c6 into CliMA:master May 20, 2019
@charleskawczynski charleskawczynski deleted the upGridStateVec branch July 10, 2019 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@simonbyrne simonbyrne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @simonbyrne