-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter by types, categories and properties seperately #39
Conversation
bed4db3
to
f25bd1b
Compare
f25bd1b
to
faa1b93
Compare
faa1b93
to
7762205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good so far (± one structural comment), will play around with it a bit more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending ci/rebase
Late to the party... |
dbb4c9e
to
7a8e124
Compare
With #53 merged I can rebase away the last few commits working around the 0x update breaking the tests. |
_In theory_ impossible unless someone mangles a hash
visualizer/ui.js
Outdated
const nodeInvalidMessage = ' node selected in selectHottestNode' | ||
|
||
// Prevent infinite loop if some future bug allows an invalid node to be returned here | ||
if (!node) throw new Error ('No' + nodeInvalidMessage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little heads-up: You might have a Lint error here because of the space between Error
and ('
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely, the linter doesn't mind, but it probably should mind, so I've changed it anyway 🙃
It looks good to me. |
The difficulty with that issue is that there are lots of points in the process that assume that data exists and it's difficult to stop them all from hitting errors. Most components expect something on each update. That comment has however given me an idea for a different way to solve the problem... and it seems to work. Will post a PR shortly, after merging this one. |
fixing a bug when parsing a hash that includes disabling merging[update] turned out to be a bug in master, fixed in Fix errors on applying unmerged tree from hash #42This mostly changes things under the hood:
typeTEMP
property (long overdue!).hide
on framesapp
,deps
, etc, and separately to types likev8
,cpp
; and for deps, the types are now the name of the dependencynative
as a dependency, there's no ambiguity betweendeps:native
andall-v8:native
exclusion filtersThis means:
init
frames. It no longer treatsinit
as a type, which means that if an init frame is not from core, it will now tell you so and treat it more appropriately. For example, here's a frame that isinit
and also from a dependency:This touches on a lot of code so will need thorough testing for regressions.