Add overridable filter function, isNodeExcluded #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Nov 20, 2018
| @@ -53,7 +53,9 @@ Pass in options as an object, including optional overrides for the following bui | |||
| - `colorHash` - Applying calculated colours using a built-in orange-to-red scale based on time spent at stack top | |||
| - `renderTooltip` - Creating and updating a tooltip giving basic frame information | |||
| - `renderLabel` - Writing frame information on the frames themselves in Canvas | |||
| - `renderStackFrameBox` - Drawing the frame rectangles in Canvas, including redrawing on hover | |||
There was a problem hiding this comment.
I don't think so, it's one of the functions that can be passed in. It was added before this PR, but it should be included in the list. Maybe I should have included it in a separate commit for clarity.
Looking back, it looks like I missed this section of the readme in my last PR ( #24 6.10.0)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the default filter logic to be overridden. Currently, d3-fg excludes based on whether the node data has a property,
type, that is in the filterTypes array (generated from theexcludeiterable).This allows that check to be overridden so that third parties can implement their own filter logic, checking against other (or multiple) properties.
As with other such overridable functions, the default function is used if no option is passed in, and the feature is disabled if null is passed instead of a function (which in this case shows everything).