-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tolerate space when parsing file directory #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it!
I think the project needs a new unit test for this fix
Hi @Eomm thanks for the review. I tried adding unit test to this but it's not straight forward. The best I can think of is to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to do it directly on .spawn
. Also, how does it partially fix the issue? what's missing?
Thanks. I'll add the unit test.
I mentioned that since this PR only aims fixing the Also, windows stripped out |
I messed up with my email config in previous commits. Had to squashed the commits. I understand that might cause some difficulty to review the changes, but please have another look. CI should be happy now. |
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no power here, but LGTM!
Thks!
Hi @RafaelGSS, do you think this can be merged? |
Partially fix: clinicjs/node-clinic#448Fixes: clinicjs/node-clinic#448