fix: tolerate space when parsing file directory (#136)

* fix: tolerate space when preloading ipc.js

Fixes: clinicjs/node-clinic#448

* test: stricter check on exit code

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

---------

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

src/index.js

@@ -116,7 +116,12 @@ class ClinicHeapProfiler extends events.EventEmitter {
   }
 
   collect (args, cb) {
-    const nodeOptions = ` -r ${path.join(__dirname, './injects/ipc.js')}`
+    let preloadPath = path.join(__dirname, './injects/ipc.js')
+    if (process.platform === 'win32') {
+      preloadPath = preloadPath.replace(/\\/g, '\\\\')
+    }
+
+    const nodeOptions = `-r "${preloadPath}"`
 
     const env = {
       ...process.env,

test/basic.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { spawn } = require('child_process')
 const fs = require('fs')
 const path = require('path')
 const { test } = require('tap')
@@ -73,6 +74,27 @@ test('cmd - test collect - data exists, html generated', t => {
   })
 })
 
+test('child_process - test spawn - filepath with spaces should be preloaded', t => {
+  const env = process.env
+
+  // double quotes are required for paths with spaces
+  env.NODE_OPTIONS = `-r "${path.join(__dirname, 'fixtures', 'file with space.js')}"`
+  if (process.platform === 'win32') {
+    env.NODE_OPTIONS = env.NODE_OPTIONS.replace(/\\/g, '\\\\')
+  }
+
+  this.process = spawn(
+    process.execPath,
+    [path.join('test', 'fixtures', 'randomHashes.js')],
+    { stdio: ['ignore', 'inherit', 'inherit'], env }
+  )
+
+  this.process.once('exit', (code) => {
+    t.equal(code, 0)
+    t.end()
+  })
+})
+
 test('cmd - test visualization - missing data', t => {
   const tool = new ClinicHeapProfiler({ debug: true })
 

test/fixtures/file with space.js

@@ -0,0 +1,4 @@
+'use strict'
+
+function noop () {}
+noop()