Skip to content

Commit

Permalink
Fixes data points on maps not showing up in reports (elastic#31949) (e…
Browse files Browse the repository at this point in the history
…lastic#32071)

* Fixes data points on maps not showing up in reports
  • Loading branch information
joelgriffith committed Feb 26, 2019
1 parent 0c27e92 commit 84a0579
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions x-pack/plugins/reporting/export_types/common/lib/screenshots.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,6 @@ export function screenshotsObservableFactory(server) {
browser => openUrl(browser, url, conditionalHeaders),
browser => browser
),
tap(() => logger.debug('injecting custom css')),
mergeMap(
browser => injectCustomCss(browser, layout),
browser => browser
),
tap(() => logger.debug('waiting for elements or items count attribute; or not found to interrupt')),
mergeMap(
browser => Rx.race(
Expand All @@ -294,6 +289,13 @@ export function screenshotsObservableFactory(server) {
({ browser, itemsCount }) => waitForElementsToBeInDOM(browser, itemsCount, layout),
({ browser, itemsCount }) => ({ browser, itemsCount })
),
// Waiting till _after_ elements have rendered before injecting our CSS
// allows for them to be displayed properly in many cases
tap(() => logger.debug('injecting custom css')),
mergeMap(
({ browser }) => injectCustomCss(browser, layout),
({ browser }) => ({ browser })
),
tap(() => logger.debug('positioning elements')),
mergeMap(
({ browser }) => positionElements(browser, layout),
Expand Down

0 comments on commit 84a0579

Please sign in to comment.