Fixes data points on maps not showing up in reports #31949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
tsullivan
reviewed
Feb 25, 2019
| @@ -121,8 +124,11 @@ visualize-app .visEditor__canvas { | |||
| * to handle this fine, but firefox moves the visualizations around. | |||
| */ | |||
| dashboard-app .react-grid-item { | |||
| height: 0 !important; /* 1. */ | |||
| width: 0 !important; /* 1. */ | |||
There was a problem hiding this comment.
Removing these makes the above block-level comment outdated.
It looks like it already was outdated though, as there is no server/lib/screenshot file anymore. I am not sure what "can only use the properties that will be manually set..." means
|
So, it turns out waiting a bit to inject the custom CSS allows all the items to render properly (and we don't have to touch hacky CSS stuff). |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
tsullivan
approved these changes
Feb 26, 2019
💚 Build Succeeded |
|
Will work on backporting this |
joelgriffith
added
v7.0.0
backport pending
Feature:Reporting
This was referenced Feb 26, 2019
joelgriffith
added a commit
that referenced
this pull request
Feb 26, 2019
joelgriffith
added a commit
that referenced
this pull request
Feb 26, 2019
|
@joelgriffith looks like this did not get backported to 7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps didn't like rendering into a parent with a 0 width/height, so I went with a more granular approach of explicitly hiding certain css properties vs the width/height hack. I've attached some before/after PDF's that highlight the fix and some subtle differences.
After.pdf
Uploading Before.pdf…