Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2.7 problem #1687

Closed
ikkeenjij36 opened this issue Jan 1, 2020 · 38 comments
Closed

python2.7 problem #1687

ikkeenjij36 opened this issue Jan 1, 2020 · 38 comments

Comments

@ikkeenjij36
Copy link

ikkeenjij36 commented Jan 1, 2020

Describe the bug
A clear and concise description of what the bug is.

Technical Specs

  1. Running on (Windows, Linux, NAS Model etc) '....'
  2. Python version '....'
  3. Download Client (NZBget, SABnbzd, Transmission) '....'
  4. Intended Media Management (SickChill, CouchPotoato, Radarr, Sonarr) '....'

Expected behavior
A clear and concise description of what you expected to happen.

Log
Please provide an extract, or full debug log that indicates the issue.
Hi all as of 2020 python.27 is niot supported anymore,wen i want to remove 2.7 from my syno box it says all programs shoulod be deleted to remove 2.7
i also got python 3 installed
is there anyway to update with not to much hassle on my syno box?

this is what i get after running the script

Please use a newer version of Python. Python End-of-Life for current versions: v2.7 in 0 days v3.5 in 256 days v3.6 in 722 days v3.7 in 1273 days Python 2.7 is no longer supported.
using ds3617
with sabnzbd radar sonar headphones

@walderston
Copy link

sabnzbd still uses python 2.7 which is why it can't be removed.

For mine, I've created a (2) file/s called nzbToSickBeard.sh / nzbToRadarr.sh
which contain the below. I've updated sabnzbd to call the .sh files.

#!/bin/bash
python3 /Applications/nzbToMedia/nzbToSickBeard.py "$@"
#!/bin/bash
python3 /Applications/nzbToMedia/nzbToRadarr.py "$@"

@ikkeenjij36
Copy link
Author

ikkeenjij36 commented Jan 1, 2020

sabnzbd still uses python 2.7 which is why it can't be removed.

For mine, I've created a (2) file/s called nzbToSickBeard.sh / nzbToRadarr.sh
which contain the below. I've updated sabnzbd to call the .sh files.

#!/bin/bash
python3 /Applications/nzbToMedia/nzbToSickBeard.py "$@"
#!/bin/bash
python3 /Applications/nzbToMedia/nzbToRadarr.py "$@"

I am using the script nzbtomedia.py for processing all
details are in autoprocessmedia.cfg
How and where do i put the files you created so sabnzbd calls on python 3.x cause i also have python 3 installed on my syno
changed .py to sh then the script doesnt kick off
thnx in advance

@walderston
Copy link

The same as I’ve done it with just nzbtomedia.sh instead.
#!/bin/bash python3 /~PATH TO ~/nzbToMedia/nzbtomedia.py "$@" and update sabnzbd to use the .sh file

@LennyM8472
Copy link

LennyM8472 commented Jan 1, 2020

Hi,

thanks for the solution, but somehow the new file won't be listed in the categories script selection. They are definitely located in the correct nzbToMedia app/script folder.

Update: It seems to only list new .py files and no .sh files

@walderston
Copy link

walderston commented Jan 1, 2020

@LennyM8472 check the permissions on the new .sh file. I had to change them to get it to show within SAB

Also mine shows at the bottom of the list

@LennyM8472
Copy link

LennyM8472 commented Jan 1, 2020

@LennyM8472 check the permissions on the new .sh file. I had to change them to get it to show within SAB

Also mine shows at the bottom of the list

Great worked, has to be set to 777 (all read write Privileges).

Now I will test a download and if the script runs.

Thanks

@LennyM8472
Copy link

in case someone has a Qnap setup with Qpython3 this is the code for the .sh files - in this case for nzbToMedia

#!/bin/bash /opt/QPython3/bin/python3 SCRIPTLOCATION/nzbToMedia.py "$@"

@ikkeenjij36
Copy link
Author

ikkeenjij36 commented Jan 1, 2020

The same as I’ve done it with just nzbtomedia.sh instead.
#!/bin/bash python3 /~PATH TO ~/nzbToMedia/nzbtomedia.py "$@" and update sabnzbd to use the .sh file

done what you said and i get this as result after running script
Exit(2) python3: can't open file '/Volmue1/scripts/nzbToMedia/': [Errno 2] No such file or directory

@walderston
Copy link

Assuming your nzbToMedia.py is located in /~Volmue1/scripts/nzbToMedia/ ?

Does the .sh file contain /~Volmue1/scripts/nzbToMedia/nzbToMedia.py or just /~Volmue1/scripts/nzbToMedia/ ? You need to call the py script from the sh script.

@ikkeenjij36
Copy link
Author

ikkeenjij36 commented Jan 1, 2020

This is exactly the path nzbToMedia is placed in,i get this error after starting the script:
'ScriptExit(2) python3: can't open file '/Volume1/scripts/nzbToMedia/nzbToMedia.py': [Errno 2] No such file or directory`

This is how the nzbToMedia.sh file looks like:
#!/bin/bash python3 /Volume1/scripts/nzbToMedia/nzbToMedia.py "$@"

@LennyM8472
Copy link

LennyM8472 commented Jan 1, 2020

This is exactly the path nzbToMedia is placed in,i get this error after starting the script:
'ScriptExit(2) python3: can't open file '/Volume1/scripts/nzbToMedia/nzbToMedia.py': [Errno 2] No such file or directory`

This is how the nzbToMedia.sh file looks like:
#!/bin/bash python3 /Volume1/scripts/nzbToMedia/nzbToMedia.py "$@"

There must be a really simpler error in your script.
Check exactly the paths - best try to run and check if all parts of the script run on ssh/terminal.
Currently your script does not find the file.
Further make sure that pyhton3 part of the script is on line 2 and not on line 1

@walderston
Copy link

@ikkeenjij36 as @LennyM8472 mentions, there must be a typo with your file location somewhere.

In SABNzbd, go to Settings -> Folders and find 'Scripts Folder'. Use that location plus /nzbToMedia.py

@PeterPan669
Copy link

PeterPan669 commented Jan 1, 2020

2 comments on the above;

  1. @ikkeenjij36, is your issue related to the fact u write Volume1 with a capital V? Remember it is cap sensitive.

  2. @walderston, I've done / tried the exact same approach, however, I still get the 'Python 2.7 is no longer supported' error with the script.

The content is:
#!/bin/bash
python3 /volume1/downloads/SCRIPTS/nzbToSickBeard.py "$@"

From CLI it runs fine, but SabNZBD forces it to run under Python2.7, inline with what Clinton Hall mentions in #1533 (comment).

However, from your comment I get the impression that you managed to overcome this. How did you do that?

-- Running this from a Synology btw.

@PeterPan669
Copy link

PeterPan669 commented Jan 1, 2020

EDIT; Apparently, pressing 'retry' within Sab also retries the exact same older command, including the older script. I'm testing it now with a new api call from Medusa. Let's consider this fixed with the .sh file :) If not, I'll post back with the results. Thanks :)

@LennyM8472
Copy link

EDIT; Apparently, pressing 'retry' within Sab also retries the exact same older command, including the older script. I'm testing it now with a new api call from Medusa; I'll post back with the results.

yes, that's what I was going to say next. You have to do a complete new download, as the new download will only have the new script file attached to it

@fbruffaert
Copy link

fbruffaert commented Jan 1, 2020

I don't like the idea of making nzbToMedia scripts fail if python version installed on the client is not supported anymore. It is not like python will stop working after the end of the support. Plus, considering the slow integration cycle of distros like Debian, this behaviour will cause issues in the future. Next deadline in 256 days with v3.5, which is not available in the repos yet.

@ikkeenjij36
Copy link
Author

2 comments on the above;

  1. @ikkeenjij36, is your issue related to the fact u write Volume1 with a capital V? Remember it is cap sensitive.
  2. @walderston, I've done / tried the exact same approach, however, I still get the 'Python 2.7 is no longer supported' error with the script.

The content is:
#!/bin/bash
python3 /volume1/downloads/SCRIPTS/nzbToSickBeard.py "$@"

From CLI it runs fine, but SabNZBD forces it to run under Python2.7, inline with what Clinton Hall mentions in #1533 (comment).

However, from your comment I get the impression that you managed to overcome this. How did you do that?

-- Running this from a Synology btw.

I got the script running without errors only now it just keeps running with rinnun nzbToMedia.sh and there is no sight of returning with no errors?
So confused now

@PeterPan669
Copy link

@ikkeenjij36, I just ran into your issue (nice: can't execute '/volume1/downloads/SCRIPTS/nzbToSickBeard.sh': No such file or directory).
This is how I fixed it;

I noticed the permissions on the file we're wrong, but no matter what I did, it wouldn't resolve;

  • I tried running chmod 777 against the file. This would set all R/RW, but it still gave the error.
  • I tried pushing the permissions from the Synology console, still gave the error.
  • I tried pushing ownership for the sc-sabnzbd on the entire directory and files, still gave me the error.
    Most likely this is due to my lack of knowledge on Linux / Unix, but I kept seeing that it said 'users' on a spot where the other (working) files would say 'sabnzbd'. See attachment "error1".
    error1

So, this is how I fixed it (not knowing any better);

  • From CLI, run 'cp -avr nzbToSickBeard.py nzbToSickBeard.sh';
  • Then, edit the nzbToSickBeard.sh file to have the correct content:
    #!/bin/bash
    python3 /volume1/downloads/SCRIPTS/nzbToSickBeard.py "$@"

This time, the file permissions looked like this (error2):
error2

And Voilà:
fix1

For me, this issue has been resolved. Thanks all, hope the above will help others!

@ikkeenjij36
Copy link
Author

ikkeenjij36 commented Jan 1, 2020

For me still probs with the script
for now it is this error
2020-01-01 22:12:51 INFO ::MAIN: Loading config from [/volume1/scripts/nzbToMedia/autoProcessMedia.cfg] 2020-01-01 22:12:51 INFO ::MAIN: Python v3.5 will reach end of life in 256 days. 2020-01-01 22:12:51 WARNING ::MAIN: Please upgrade to a more recent Python version. 2020-01-01 22:12:51 INFO ::MAIN: Checking database structure... 2020-01-01 22:12:51 INFO ::MAIN: Checking if git needs an update 2020-01-01 22:12:53 INFO ::MAIN: There is a newer version available (you're 14 commits behind) 2020-01-01 22:12:53 INFO ::MAIN: Auto-Updating nzbToMedia, Please wait ... 2020-01-01 22:12:56 ERROR ::MAIN: Update failed, not restarting. Check your log for more information. 2020-01-01 22:12:56 INFO ::MAIN: nzbToMedia Version:46b2e8998ce7c0e4b853272f0bdb06a558852c81 Branch:master (Linux 3.10.102) 2020-01-01 22:12:56 WARNING ::MAIN: Failed to locate ffprobe. Video corruption detection disabled! 2020-01-01 22:12:56 WARNING ::MAIN: Install ffmpeg with x264 support to enable this feature ..
still waiting for the first succesful run of the script
lots of more errors showed up
why is this happening after python 2.7 is eol?
Maybe clinton hall can check this and help with a solution?
next log with errors:
`[22:32:57] [INFO]::MAIN: Loading config from [/volume1/scripts/nzbToMedia/autoProcessMedia.cfg]
[22:32:57] [INFO]::ENVIRONMENT: SAB_OVERSIZED: 0
[22:32:57] [INFO]::ENVIRONMENT: LANG: en_US.UTF-8
[22:32:57] [INFO]::ENVIRONMENT: TERM: vt102
[22:32:57] [INFO]::ENVIRONMENT: SAB_SCRIPT: nzbToMedia.sh
[22:32:57] [INFO]::ENVIRONMENT: AVAHI_COMPAT_NOWARN: 1
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_DSM_VERSION_BUILD: 15284
[22:32:57] [INFO]::ENVIRONMENT: SHLVL: 3
[22:32:57] [INFO]::ENVIRONMENT: SAB_FILENAME: Vikings S01.1080p BluRay x264-SCC.nzb
[22:32:57] [INFO]::ENVIRONMENT: SAB_ORIG_NZB_GZ: /volume1/downloads/incomplete/Vikings S01.1080p BluRay x264-SCC/ADMIN/Vikings S01.1080p BluRay x264-SCC.nzb.gz
[22:32:57] [INFO]::ENVIRONMENT: SAB_UNPACK: 1
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_DSM_VERSION_MINOR: 1
[22:32:57] [INFO]::ENVIRONMENT: SAB_CAT: tvseries
[22:32:57] [INFO]::ENVIRONMENT: SAB_MULTIPAR_COMMAND:
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_USERNAME: admin
[22:32:57] [INFO]::ENVIRONMENT: UPSTART_JOB: pkgctl-sabnzbd
[22:32:57] [INFO]::ENVIRONMENT: SAB_AVG_BPS: 25779
[22:32:57] [INFO]::ENVIRONMENT: SAB_PROGRAM_DIR: /volume1/@appstore/sabnzbd/share/SABnzbd
[22:32:57] [INFO]::ENVIRONMENT: SAB_PAR2_COMMAND: /volume1/@appstore/sabnzbd/bin/par2
[22:32:57] [INFO]::ENVIRONMENT: SAB_DUPLICATE: 0
[22:32:57] [INFO]::ENVIRONMENT: SAB_FAIL_MSG:
[22:32:57] [INFO]::ENVIRONMENT: SAB_REPAIR: 1
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKGNAME: sabnzbd
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKGDEST_VOL: /volume1
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_DSM_VERSION_MAJOR: 6
[22:32:57] [INFO]::ENVIRONMENT: SAB_AGE: 2055d
[22:32:57] [INFO]::ENVIRONMENT: PATH: /volume1/@appstore/sabnzbd/bin:/volume1/@appstore/sabnzbd/env/bin:/usr/local/python/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/syno/sbin:/usr/syno/bin:/usr/local/sbin:/usr/local/bin
[22:32:57] [INFO]::ENVIRONMENT: SAB_BYTES_DOWNLOADED: 32587709991
[22:32:57] [INFO]::ENVIRONMENT: SAB_ZIP_COMMAND:
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKGPORT: 8080
[22:32:57] [INFO]::ENVIRONMENT: SAB_NZO_ID: SABnzbd_nzo_wPa2mD
[22:32:57] [INFO]::ENVIRONMENT: SAB_GROUP: alt.binaries.boneless
[22:32:57] [INFO]::ENVIRONMENT: SAB_BYTES: 37481336821
[22:32:57] [INFO]::ENVIRONMENT: SAB_STATUS: Running
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_TEMP_LOGFILE: /tmp/synopkgmgr.log-sabnzbd
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKGVER: 2.3.9-40
[22:32:57] [INFO]::ENVIRONMENT: SAB_FINAL_NAME: Vikings_S01.1080p_BluRay_x264-SCC
[22:32:57] [INFO]::ENVIRONMENT: SELF: sabnzbd
[22:32:57] [INFO]::ENVIRONMENT: SAB_PRIORITY: 0
[22:32:57] [INFO]::ENVIRONMENT: PWD: /volume1/@appstore/sabnzbd/share/SABnzbd
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_DSM_ARCH: broadwell
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKGDEST: /volume1/@appstore/sabnzbd
[22:32:57] [INFO]::ENVIRONMENT: SAB_COMPLETE_DIR: /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC
[22:32:57] [INFO]::ENVIRONMENT: SAB_UNWANTED_EXT: 0
[22:32:57] [INFO]::ENVIRONMENT: SAB_7ZIP_COMMAND: /volume1/@appstore/sabnzbd/bin/7za
[22:32:57] [INFO]::ENVIRONMENT: SAB_PP_STATUS: 0
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_DSM_LANGUAGE: nld
[22:32:57] [INFO]::ENVIRONMENT: SAB_BYTES_TRIED: 37481336821
[22:32:57] [INFO]::ENVIRONMENT: SYNOPKG_PKG_STATUS: START
[22:32:57] [INFO]::ENVIRONMENT: SAB_RAR_COMMAND: /volume1/@appstore/sabnzbd/bin/unrar
[22:32:57] [INFO]::ENVIRONMENT: SAB_PP: 3
[22:32:57] [INFO]::ENVIRONMENT: UPSTART_INSTANCE:
[22:32:57] [INFO]::ENVIRONMENT: SAB_ENCRYPTED: 0
[22:32:57] [INFO]::ENVIRONMENT: SAB_VERSION: 2.3.9
[22:32:57] [INFO]::ENVIRONMENT: SAB_URL: Vikings S01.1080p BluRay x264-SCC.nzb
[22:32:57] [INFO]::ENVIRONMENT: SAB_FAILURE_URL:
[22:32:57] [INFO]::ENVIRONMENT: SAB_DOWNLOAD_TIME: 1234
[22:32:57] [INFO]::ENVIRONMENT: SAB_PASSWORD:
[22:32:57] [INFO]::ENVIRONMENT: _: /usr/local/bin/python3
/volume1/scripts/nzbToMedia/eol.py:146: LifetimeWarning: Python 3.5 is no longer supported.
warnings.warn(msg, LifetimeWarning)
[22:32:57] [INFO]::MAIN: Python v3.5 will reach end of life in 256 days.
[22:32:57] [WARNING]::MAIN: Please upgrade to a more recent Python version.
[22:32:57] [INFO]::MAIN: Checking database structure...
[22:32:57] [DEBUG]::MAIN: Checking Initial Schema database upgrade
[22:32:57] [DB]::MAIN: nzbtomedia.db: SELECT 1 FROM sqlite_master WHERE name = ?; with args ('db_version',)
[22:32:57] [DB]::MAIN: nzbtomedia.db: SELECT db_version FROM db_version
[22:32:57] [DEBUG]::MAIN: InitialSchema upgrade not required
[22:32:57] [DEBUG]::MAIN: Checking if we can use git commands: git version
[22:32:57] [DEBUG]::MAIN: Executing git version with your shell in /volume1/scripts/nzbToMedia
[22:32:57] [DEBUG]::MAIN: git output: git version 2.19.2
[22:32:57] [DEBUG]::MAIN: git version : returned successful
[22:32:57] [DEBUG]::MAIN: Using: git
[22:32:57] [DEBUG]::MAIN: Executing git symbolic-ref -q HEAD with your shell in /volume1/scripts/nzbToMedia
[22:32:57] [DEBUG]::MAIN: git output: refs/heads/master
[22:32:57] [DEBUG]::MAIN: git symbolic-ref -q HEAD : returned successful
[22:32:57] [INFO]::MAIN: Checking if git needs an update
[22:32:57] [DEBUG]::MAIN: Executing git rev-parse HEAD with your shell in /volume1/scripts/nzbToMedia
[22:32:57] [DEBUG]::MAIN: git output: 46b2e89
[22:32:57] [DEBUG]::MAIN: git rev-parse HEAD : returned successful
[22:32:57] [DEBUG]::MAIN: Executing git fetch origin with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output:
[22:32:58] [DEBUG]::MAIN: git fetch origin : returned successful
[22:32:58] [DEBUG]::MAIN: Executing git rev-parse --verify --quiet '@{upstream}' with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output: 2e7d4a5
[22:32:58] [DEBUG]::MAIN: git rev-parse --verify --quiet '@{upstream}' : returned successful
[22:32:58] [DEBUG]::MAIN: Executing git rev-list --left-right '@{upstream}'...HEAD with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output: <2e7d4a58633b4b7924496ba849636bd5bb3b98cc
<9111f815f9edaad117915baad01b8c6a136f587c
<feb4e36c4c1dab5d6b4d467a1355076c50d28de6
<cbd0c25c882e6e84c5e2e32ab8bc9886336e2fdc
<75ecbd48629f31c0456c99b726eff99a650e1530
<d95e4e56c8569bc41a085336a797044ca2c4a1d9
<0d7c59f1f035d51a7409449bc4e335928a6b29bd
<fdaa00775674a887bb4002e82b89ba6de3fa9083
<5cd449632f1f46eb7ad840cd2b39d4206242ef9f
<70ab7d3d611475d0085082aade49d7163e6eb0d1
<fde87148627ff66650201087dab840dfd6fb5d70
<c92588c3bea0b614a4b70cc77d036139c5775f80
<1814bd5ae1a40885217e7a4427768b689b93542b
<80ef0d094e1c316ff9e688d34489b4a1846c6895
[22:32:58] [DEBUG]::MAIN: git rev-list --left-right '@{upstream}'...HEAD : returned successful
[22:32:58] [DEBUG]::MAIN: cur_commit = 46b2e89 % (newest_commit)= 2e7d4a5, num_commits_behind = 14, num_commits_ahead = 0
[22:32:58] [INFO]::MAIN: There is a newer version available (you're 14 commits behind)
[22:32:58] [INFO]::MAIN: Auto-Updating nzbToMedia, Please wait ...
[22:32:58] [DEBUG]::MAIN: Executing git rev-parse HEAD with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output: 46b2e89
[22:32:58] [DEBUG]::MAIN: git rev-parse HEAD : returned successful
[22:32:58] [DEBUG]::MAIN: Executing git fetch origin with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output:
[22:32:58] [DEBUG]::MAIN: git fetch origin : returned successful
[22:32:58] [DEBUG]::MAIN: Executing git rev-parse --verify --quiet '@{upstream}' with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output: 2e7d4a5
[22:32:58] [DEBUG]::MAIN: git rev-parse --verify --quiet '@{upstream}' : returned successful
[22:32:58] [DEBUG]::MAIN: Executing git rev-list --left-right '@{upstream}'...HEAD with your shell in /volume1/scripts/nzbToMedia
[22:32:58] [DEBUG]::MAIN: git output: <2e7d4a58633b4b7924496ba849636bd5bb3b98cc
<9111f815f9edaad117915baad01b8c6a136f587c
<feb4e36c4c1dab5d6b4d467a1355076c50d28de6
<cbd0c25c882e6e84c5e2e32ab8bc9886336e2fdc
<75ecbd48629f31c0456c99b726eff99a650e1530
<d95e4e56c8569bc41a085336a797044ca2c4a1d9
<0d7c59f1f035d51a7409449bc4e335928a6b29bd
<fdaa00775674a887bb4002e82b89ba6de3fa9083
<5cd449632f1f46eb7ad840cd2b39d4206242ef9f
<70ab7d3d611475d0085082aade49d7163e6eb0d1
<fde87148627ff66650201087dab840dfd6fb5d70
<c92588c3bea0b614a4b70cc77d036139c5775f80
<1814bd5ae1a40885217e7a4427768b689b93542b
<80ef0d094e1c316ff9e688d34489b4a1846c6895
[22:32:58] [DEBUG]::MAIN: git rev-list --left-right '@{upstream}'...HEAD : returned successful
[22:32:58] [DEBUG]::MAIN: cur_commit = 46b2e89 % (newest_commit)= 2e7d4a5, num_commits_behind = 14, num_commits_ahead = 0
[22:32:58] [DEBUG]::MAIN: Executing git pull origin master with your shell in /volume1/scripts/nzbToMedia
[22:32:59] [DEBUG]::MAIN: git output: From https://github.com/clinton-hall/nzbToMedia

  • branch master -> FETCH_HEAD
    error: Your local changes to the following files would be overwritten by merge:
    .bumpversion.cfg
    autoProcessMedia.cfg.spec
    azure-pipelines.yml
    cleanup.py
    core/init.py
    core/auto_process/movies.py
    core/configuration.py
    core/forks.py
    core/plugins/subtitles.py
    core/utils/files.py
    core/version_check.py
    eol.py
    libs/common/qbittorrent/client.py
    nzbToMedia.py
    setup.py
    Please commit your changes or stash them before you merge.
    Aborting
    Updating 46b2e89..2e7d4a5
    [22:32:59] [DEBUG]::MAIN: git pull origin master returned : From https://github.com/clinton-hall/nzbToMedia
  • branch master -> FETCH_HEAD
    error: Your local changes to the following files would be overwritten by merge:
    .bumpversion.cfg
    autoProcessMedia.cfg.spec
    azure-pipelines.yml
    cleanup.py
    core/init.py
    core/auto_process/movies.py
    core/configuration.py
    core/forks.py
    core/plugins/subtitles.py
    core/utils/files.py
    core/version_check.py
    eol.py
    libs/common/qbittorrent/client.py
    nzbToMedia.py
    setup.py
    Please commit your changes or stash them before you merge.
    Aborting
    Updating 46b2e89..2e7d4a5
    [22:32:59] [ERROR]::MAIN: Update failed, not restarting. Check your log for more information.
    [22:32:59] [INFO]::MAIN: nzbToMedia Version:46b2e8998ce7c0e4b853272f0bdb06a558852c81 Branch:master (Linux 3.10.102)
    [22:32:59] [WARNING]::MAIN: Failed to locate ffprobe. Video corruption detection disabled!
    [22:32:59] [WARNING]::MAIN: Install ffmpeg with x264 support to enable this feature ...
    [22:32:59] [INFO]::MAIN: #########################################################
    [22:32:59] [INFO]::MAIN: ## ..::[nzbToMedia.py]::.. ##
    [22:32:59] [INFO]::MAIN: #########################################################
    [22:32:59] [DEBUG]::MAIN: Options passed into nzbToMedia: ['/volume1/scripts/nzbToMedia/nzbToMedia.py', '/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC', 'Vikings S01.1080p BluRay x264-SCC.nzb', 'Vikings_S01.1080p_BluRay_x264-SCC', '', 'tvseries', 'alt.binaries.boneless', '0', '']
    [22:32:59] [INFO]::MAIN: Script triggered from SABnzbd 0.7.17+
    [22:32:59] [DEBUG]::MAIN: Searching for nzoid from SAbnzbd ...
    [22:32:59] [DEBUG]::MAIN: Adding NZB download info for directory /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC to database
    [22:32:59] [DB]::MAIN: nzbtomedia.db: UPDATE downloads SET client_agent = ?, status = ?, input_id = ?, input_hash = ?, input_name = ?, last_update = ? WHERE input_directory = ? with args ['sabnzbd', 0, 'None', 'None', "b'Vikings S01.1080p BluRay x264-SCC.nzb'", 737425, "b'/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC'"]
    [22:32:59] [DB]::MAIN: nzbtomedia.db: INSERT OR IGNORE INTO downloads (client_agent, status, input_id, input_hash, input_name, last_update) VALUES (?, ?, ?, ?, ?, ?) with args ['sabnzbd', 0, 'None', 'None', "b'Vikings S01.1080p BluRay x264-SCC.nzb'", 737425]
    [22:33:01] [INFO]::MAIN: Auto-detected SECTION:NzbDrone
    [22:33:01] [DEBUG]::MAIN: Checking for archives to extract in directory: /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC
    [22:33:01] [INFO]::MAIN: Calling NzbDrone:tvseries to post-process:Vikings S01.1080p BluRay x264-SCC.nzb
    [22:33:01] [DEBUG]::SERVER: Attempting to connect to server at http://localhost:8989
    [22:33:01] [DEBUG]::SERVER: Server responded at http://localhost:8989
    [22:33:01] [INFO]::MAIN: Attempting to verify tvseries fork
    [22:33:01] [INFO]::MAIN: NzbDrone:tvseries fork set to default
    [22:33:01] [DEBUG]::EXCEPTION: Replacing file name scc with directory name Vikings.S01.1080p.BluRay.x264-SCC
    [22:33:01] [DEBUG]::EXCEPTION: Replacing file name /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC/scc.nfo with download name /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC.nfo
    [22:33:01] [INFO]::MAIN: FLATTEN: Flattening directory: /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC
    [22:33:01] [DEBUG]::MAIN: Checking for empty folders in:/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC
    [22:33:01] [DEBUG]::MAIN: Checking for empty folders in:/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC
    [22:33:01] [DEBUG]::MAIN: Checking for empty folders in:/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC/Proof
    [22:33:01] [DEBUG]::MAIN: Removing empty folder:/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC/Proof
    [22:33:01] [DEBUG]::MAIN: Removing empty folder:/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC/Vikings.S01.1080p.BluRay.x264-SCC
    [22:33:01] [POSTPROCESS]::NZBDRONE: SUCCESS: The download succeeded, sending a post-process request
    [22:33:01] [DEBUG]::NZBDRONE: path: /volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC
    [22:33:01] [DEBUG]::NZBDRONE: Opening URL: http://localhost:8989/api/command with data: {"path": "/volume1/downloads/complete/tvseries/Vikings_S01.1080p_BluRay_x264-SCC", "importMode": "Copy", "name": "DownloadedEpisodesScan"}
    [22:33:02] [WARNING]::NZBDRONE: No scan id was returned due to: the JSON object must be str, not 'bytes'
    [22:33:02] [ERROR]::MAIN: A problem was reported in the /volume1/scripts/nzbToMedia/nzbToMedia.py script.
    Changing to directory: /volume1/scripts/nzbToMedia

-- Cleaning bytecode --
b'Removing pycache/\n'
b'Removing pycache/\n'

-- Cleaning folders: ['core', 'libs'] --
No folders to clean

Returning to directory: /volume1/@appstore/sabnzbd/share/SABnzbd

-- Cleanup finished --

Changing to directory: /volume1/scripts/nzbToMedia

-- Cleaning bytecode --
b'Removing core/pycache/\nRemoving core/auto_process/pycache/\nRemoving core/extractor/pycache/\nRemoving core/plugins/pycache/\nRemoving core/plugins/downloaders/pycache/\nRemoving core/plugins/downloaders/nzb/pycache/\nRemoving core/plugins/downloaders/torrent/pycache/\nRemoving core/utils/pycache/\nRemoving libs/pycache/\nRemoving libs/common/pycache/\nRemoving libs/common/babelfish/pycache/\nRemoving libs/common/babelfish/converters/pycache/\nRemoving libs/common/beets/pycache/\nRemoving libs/common/beets/util/pycache/\nRemoving libs/common/bs4/pycache/\nRemoving libs/common/bs4/builder/pycache/\nRemoving libs/common/certifi/pycache/\nRemoving libs/common/chardet/pycache/\nRemoving libs/common/dateutil/pycache/\nRemoving libs/common/dateutil/parser/pycache/\nRemoving libs/common/dateutil/tz/pycache/\nRemoving libs/common/dogpile/pycache/\nRemoving libs/common/dogpile/cache/pycache/\nRemoving libs/common/dogpile/cache/backends/pycache/\nRemoving libs/common/dogpile/util/pycache/\nRemoving libs/common/guessit/pycache/\nRemoving libs/common/guessit/rules/pycache/\nRemoving libs/common/guessit/rules/common/pycache/\nRemoving libs/common/guessit/rules/markers/pycache/\nRemoving libs/common/guessit/rules/properties/pycache/\nRemoving libs/common/idna/pycache/\nRemoving libs/common/mutagen/pycache/\nRemoving libs/common/mutagen/asf/pycache/\nRemoving libs/common/mutagen/id3/pycache/\nRemoving libs/common/mutagen/mp4/pycache/\nRemoving libs/common/pkg_resources/pycache/\nRemoving libs/common/pkg_resources/_vendor/pycache/\nRemoving libs/common/pkg_resources/_vendor/packaging/pycache/\nRemoving libs/common/pkg_resources/extern/pycache/\nRemoving libs/common/pysrt/pycache/\nRemoving libs/common/qbittorrent/pycache/\nRemoving libs/common/rebulk/pycache/\nRemoving libs/common/rencode/pycache/\nRemoving libs/common/requests/pycache/\nRemoving libs/common/stevedore/pycache/\nRemoving libs/common/subliminal/pycache/\nRemoving libs/common/subliminal/providers/pycache/\nRemoving libs/common/transmissionrpc/pycache/\nRemoving libs/common/unidecode/pycache/\nRemoving libs/common/urllib3/pycache/\nRemoving libs/common/urllib3/contrib/pycache/\nRemoving libs/common/urllib3/packages/pycache/\nRemoving libs/common/urllib3/packages/ssl_match_hostname/pycache/\nRemoving libs/common/urllib3/util/pycache/\nRemoving libs/common/yaml/pycache/\nRemoving libs/custom/synchronousdeluge/pycache/\nRemoving libs/custom/utorrent/pycache/\n'
b'Removing core/pycache/\nRemoving core/auto_process/pycache/\nRemoving core/extractor/pycache/\nRemoving core/plugins/pycache/\nRemoving core/plugins/downloaders/pycache/\nRemoving core/plugins/downloaders/nzb/pycache/\nRemoving core/plugins/downloaders/torrent/pycache/\nRemoving core/utils/pycache/\nRemoving libs/pycache/\nRemoving libs/common/pycache/\nRemoving libs/common/babelfish/pycache/\nRemoving libs/common/babelfish/converters/pycache/\nRemoving libs/common/beets/pycache/\nRemoving libs/common/beets/util/pycache/\nRemoving libs/common/bs4/pycache/\nRemoving libs/common/bs4/builder/pycache/\nRemoving libs/common/certifi/pycache/\nRemoving libs/common/chardet/pycache/\nRemoving libs/common/dateutil/pycache/\nRemoving libs/common/dateutil/parser/pycache/\nRemoving libs/common/dateutil/tz/pycache/\nRemoving libs/common/dogpile/pycache/\nRemoving libs/common/dogpile/cache/pycache/\nRemoving libs/common/dogpile/cache/backends/pycache/\nRemoving libs/common/dogpile/util/pycache/\nRemoving libs/common/guessit/pycache/\nRemoving libs/common/guessit/rules/pycache/\nRemoving libs/common/guessit/rules/common/pycache/\nRemoving libs/common/guessit/rules/markers/pycache/\nRemoving libs/common/guessit/rules/properties/pycache/\nRemoving libs/common/idna/pycache/\nRemoving libs/common/mutagen/pycache/\nRemoving libs/common/mutagen/asf/pycache/\nRemoving libs/common/mutagen/id3/pycache/\nRemoving libs/common/mutagen/mp4/pycache/\nRemoving libs/common/pkg_resources/pycache/\nRemoving libs/common/pkg_resources/_vendor/pycache/\nRemoving libs/common/pkg_resources/_vendor/packaging/pycache/\nRemoving libs/common/pkg_resources/extern/pycache/\nRemoving libs/common/pysrt/pycache/\nRemoving libs/common/qbittorrent/pycache/\nRemoving libs/common/rebulk/pycache/\nRemoving libs/common/rencode/pycache/\nRemoving libs/common/requests/pycache/\nRemoving libs/common/stevedore/pycache/\nRemoving libs/common/subliminal/pycache/\nRemoving libs/common/subliminal/providers/pycache/\nRemoving libs/common/transmissionrpc/pycache/\nRemoving libs/common/unidecode/pycache/\nRemoving libs/common/urllib3/pycache/\nRemoving libs/common/urllib3/contrib/pycache/\nRemoving libs/common/urllib3/packages/pycache/\nRemoving libs/common/urllib3/packages/ssl_match_hostname/pycache/\nRemoving libs/common/urllib3/util/pycache/\nRemoving libs/common/yaml/pycache/\nRemoving libs/custom/synchronousdeluge/pycache/\nRemoving libs/custom/utorrent/pycache/\n'

-- Cleaning folders: ['core', 'libs'] --
No folders to clean

Returning to directory: /volume1/@appstore/sabnzbd/share/SABnzbd

-- Cleanup finished --

NzbDrone: Failed to post-process - Returned log from NzbDrone was not as expected.!`

@suprawsmninja
Copy link

It's not like python 2.7 will stop working, it's just no longer maintained.
There is no point in nzbToMedia working with 3 when SABnzb only runs on 2.7

Don't bother messing around, simply edit the eol.py file in your nzbToMedia directory, give your self another 100 days.

change
def check(version=None, grace_period=0):
to
def check(version=None, grace_period=100):

and
def raise_for_status(version=None, grace_period=0):
to
def raise_for_status(version=None, grace_period=100):

@djskippy50
Copy link

It's not like python 2.7 will stop working, it's just no longer maintained.
There is no point in nzbToMedia working with 3 when SABnzb only runs on 2.7

Don't bother messing around, simply edit the eol.py file in your nzbToMedia directory, give your self another 100 days.

change
def check(version=None, grace_period=0):
to
def check(version=None, grace_period=100):

and
def raise_for_status(version=None, grace_period=0):
to
def raise_for_status(version=None, grace_period=100):

Thank you. This is exactly what I needed.

@tchirou
Copy link

tchirou commented Jan 2, 2020

It's not like python 2.7 will stop working, it's just no longer maintained.
There is no point in nzbToMedia working with 3 when SABnzb only runs on 2.7

Don't bother messing around, simply edit the eol.py file in your nzbToMedia directory, give your self another 100 days.

change
def check(version=None, grace_period=0):
to
def check(version=None, grace_period=100):

and
def raise_for_status(version=None, grace_period=0):
to
def raise_for_status(version=None, grace_period=100):

The best post of the year so far :D !!!

@drallgood
Copy link

See also sabnzbd/sabnzbd#1203 for the status of the Py3 migration

@XxUnkn0wnxX
Copy link

XxUnkn0wnxX commented Jan 2, 2020

this guide somewhat helps: https://opensource.com/article/19/5/python-3-default-mac
although on Catalina pyenv doesnt want to compile anything to many issues like pyexpat module missing

just run ln -sf /usr/local/bin/python3 /usr/local/bin/python

and if using hydra via wrapper just use launchd to run it with python2 enviroment variable set.

@mannibis
Copy link

mannibis commented Jan 2, 2020

Linuxserver.io's docker container for NZBGet still doesn't include python3. I believe there is a pull request pending that will add it to the image but as of now, I have had to edit eol.py to increase the grace period as the user above pointed out.

@ikkeenjij36
Copy link
Author

ikkeenjij36 commented Jan 2, 2020

It's not like python 2.7 will stop working, it's just no longer maintained.
There is no point in nzbToMedia working with 3 when SABnzb only runs on 2.7

Don't bother messing around, simply edit the eol.py file in your nzbToMedia directory, give your self another 100 days.

change
def check(version=None, grace_period=0):
to
def check(version=None, grace_period=100):

and
def raise_for_status(version=None, grace_period=0):
to
def raise_for_status(version=None, grace_period=100):

Thanks for your tempory solution,now all works almost fine this resolved the pyhtom problem

Now a small other thing maybe someone can help me too with this one

`2020-01-01 22:32:57 DEBUG ::MAIN: InitialSchema upgrade not required
2020-01-01 22:32:57 DEBUG ::MAIN: Checking if we can use git commands: git version
2020-01-01 22:32:57 DEBUG ::MAIN: Executing git version with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:57 DEBUG ::MAIN: git output: git version 2.19.2
2020-01-01 22:32:57 DEBUG ::MAIN: git version : returned successful
2020-01-01 22:32:57 DEBUG ::MAIN: Using: git
2020-01-01 22:32:57 DEBUG ::MAIN: Executing git symbolic-ref -q HEAD with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:57 DEBUG ::MAIN: git output: refs/heads/master
2020-01-01 22:32:57 DEBUG ::MAIN: git symbolic-ref -q HEAD : returned successful
2020-01-01 22:32:57 INFO ::MAIN: Checking if git needs an update
2020-01-01 22:32:57 DEBUG ::MAIN: Executing git rev-parse HEAD with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:57 DEBUG ::MAIN: git output: 46b2e89
2020-01-01 22:32:57 DEBUG ::MAIN: git rev-parse HEAD : returned successful
2020-01-01 22:32:57 DEBUG ::MAIN: Executing git fetch origin with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output:
2020-01-01 22:32:58 DEBUG ::MAIN: git fetch origin : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git rev-parse --verify --quiet '@{upstream}' with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output: 2e7d4a5
2020-01-01 22:32:58 DEBUG ::MAIN: git rev-parse --verify --quiet '@{upstream}' : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git rev-list --left-right '@{upstream}'...HEAD with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output: <2e7d4a58633b4b7924496ba849636bd5bb3b98cc
<9111f815f9edaad117915baad01b8c6a136f587c
<feb4e36c4c1dab5d6b4d467a1355076c50d28de6
<cbd0c25c882e6e84c5e2e32ab8bc9886336e2fdc
<75ecbd48629f31c0456c99b726eff99a650e1530
<d95e4e56c8569bc41a085336a797044ca2c4a1d9
<0d7c59f1f035d51a7409449bc4e335928a6b29bd
<fdaa00775674a887bb4002e82b89ba6de3fa9083
<5cd449632f1f46eb7ad840cd2b39d4206242ef9f
<70ab7d3d611475d0085082aade49d7163e6eb0d1
<fde87148627ff66650201087dab840dfd6fb5d70
<c92588c3bea0b614a4b70cc77d036139c5775f80
<1814bd5ae1a40885217e7a4427768b689b93542b
<80ef0d094e1c316ff9e688d34489b4a1846c6895
2020-01-01 22:32:58 DEBUG ::MAIN: git rev-list --left-right '@{upstream}'...HEAD : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: cur_commit = 46b2e89 % (newest_commit)= 2e7d4a5, num_commits_behind = 14, num_commits_ahead = 0
2020-01-01 22:32:58 INFO ::MAIN: There is a newer version available (you're 14 commits behind)
2020-01-01 22:32:58 INFO ::MAIN: Auto-Updating nzbToMedia, Please wait ...
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git rev-parse HEAD with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output: 46b2e89
2020-01-01 22:32:58 DEBUG ::MAIN: git rev-parse HEAD : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git fetch origin with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output:
2020-01-01 22:32:58 DEBUG ::MAIN: git fetch origin : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git rev-parse --verify --quiet '@{upstream}' with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output: 2e7d4a5
2020-01-01 22:32:58 DEBUG ::MAIN: git rev-parse --verify --quiet '@{upstream}' : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git rev-list --left-right '@{upstream}'...HEAD with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:58 DEBUG ::MAIN: git output: <2e7d4a58633b4b7924496ba849636bd5bb3b98cc
<9111f815f9edaad117915baad01b8c6a136f587c
<feb4e36c4c1dab5d6b4d467a1355076c50d28de6
<cbd0c25c882e6e84c5e2e32ab8bc9886336e2fdc
<75ecbd48629f31c0456c99b726eff99a650e1530
<d95e4e56c8569bc41a085336a797044ca2c4a1d9
<0d7c59f1f035d51a7409449bc4e335928a6b29bd
<fdaa00775674a887bb4002e82b89ba6de3fa9083
<5cd449632f1f46eb7ad840cd2b39d4206242ef9f
<70ab7d3d611475d0085082aade49d7163e6eb0d1
<fde87148627ff66650201087dab840dfd6fb5d70
<c92588c3bea0b614a4b70cc77d036139c5775f80
<1814bd5ae1a40885217e7a4427768b689b93542b
<80ef0d094e1c316ff9e688d34489b4a1846c6895
2020-01-01 22:32:58 DEBUG ::MAIN: git rev-list --left-right '@{upstream}'...HEAD : returned successful
2020-01-01 22:32:58 DEBUG ::MAIN: cur_commit = 46b2e89 % (newest_commit)= 2e7d4a5, num_commits_behind = 14, num_commits_ahead = 0
2020-01-01 22:32:58 DEBUG ::MAIN: Executing git pull origin master with your shell in /volume1/scripts/nzbToMedia
2020-01-01 22:32:59 DEBUG ::MAIN: git output: From https://github.com/clinton-hall/nzbToMedia

  • branch master -> FETCH_HEAD
    error: Your local changes to the following files would be overwritten by merge:
    .bumpversion.cfg
    autoProcessMedia.cfg.spec
    azure-pipelines.yml
    cleanup.py
    core/init.py
    core/auto_process/movies.py
    core/configuration.py
    core/forks.py
    core/plugins/subtitles.py
    core/utils/files.py
    core/version_check.py
    eol.py
    libs/common/qbittorrent/client.py
    nzbToMedia.py
    setup.py
    Please commit your changes or stash them before you merge.
    Aborting
    Updating 46b2e89..2e7d4a5
    2020-01-01 22:32:59 DEBUG ::MAIN: git pull origin master returned : From https://github.com/clinton-hall/nzbToMedia
  • branch master -> FETCH_HEAD
    error: Your local changes to the following files would be overwritten by merge:
    .bumpversion.cfg
    autoProcessMedia.cfg.spec
    azure-pipelines.yml
    cleanup.py
    core/init.py
    core/auto_process/movies.py
    core/configuration.py
    core/forks.py
    core/plugins/subtitles.py
    core/utils/files.py
    core/version_check.py
    eol.py
    libs/common/qbittorrent/client.py
    nzbToMedia.py
    setup.py
    Please commit your changes or stash them before you merge.
    Aborting
    Updating 46b2e89..2e7d4a5
    2020-01-01 22:32:59 ERROR ::MAIN: Update failed, not restarting. Check your log for more information.
    2020-01-01 22:32:59 INFO ::MAIN: nzbToMedia Version:46b2e8998ce7c0e4b853272f0bdb06a558852c81 Branch:master (Linux 3.10.102)
    2020-01-01 22:32:59 WARNING ::MAIN: Failed to locate ffprobe. Video corruption detection disabled!
    2020-01-01 22:32:59 WARNING ::MAIN: Install ffmpeg with x264 support to enable this feature ...`
    Do i need to worry and is nzbtomedia not the latest now?
    I also saw that there is a sabnzbd with a python 3 build?
    How do i install that one on my synology then?

@XxUnkn0wnxX
Copy link

XxUnkn0wnxX commented Jan 3, 2020

@ikkeenjij36 this happens when you have manually overwritten the files & git wont update nzbtomedia. you need to either commit them or stash them the files you edited. but just delete the files you manualy edited then run git reset --hard (will restore original files) in the folder & then do git pull .

Or just disable auto_update in autoProcessMedia.cfg

@ted46045
Copy link

ted46045 commented Jan 3, 2020

alternativly you can just change the date listed in the eol.py to be something else (like 2030 instead of 2020) if the 100 day grace period isnt enough

@clinton-hall clinton-hall mentioned this issue Jan 4, 2020
4 tasks
@clinton-hall
Copy link
Owner

sorry all for the drama.... looks like I took the wrong week to disappear into the bush without internet access...

I have removed the python2.7 eol failure and just set this to log and remind you to update. I'll try and keep support for python2 for now, but note that I may not make all new features compatible with python2....

@skarekrow
Copy link

skarekrow commented Jan 4, 2020 via email

@clinton-hall
Copy link
Owner

thanks @skarekrow

There are clearly a lot of divided opinions on this issue... I suspect this is only 1 of many apps that will cause some debate around continued, or not, support for python2.

SABnzbd are working on a python3 version, NZBget has a shell override option which allows you for force the binary to call scripts, and I had made some simple .sh scripts available to "pass-through" to any python binary.

Yes, some containers/apps do make it hard, but having built some Apps for NAS before I know it is pretty easy to only link the needed binaries into the PATH (i.e. when you have a python3.6 binary, python3 suymlinks to that, and python symlinks to python3, all inside some repository location it becomes easier just to symlink 1 'python' into the System Path). I'm not saying it is the "right" thing, but years down the track when Apps are all built on top of each other, some of these NAS systems ans busybox etc can become very temperamental when trying to figure out which command to call....

from what I have seen python is the only truly reliable call, but in a world where python2 is now end-of-life, what should that mean.

@timrettop
Copy link

For those having this issue with linuxserver/nzbget you can modify the scripts shell settings via these instructions, which for me addressed the issue and now the nzbToMedia script runs successfully (without altering eol.py)
https://github.com/linuxserver/docker-nzbget#python-3-transition

@mannibis
Copy link

mannibis commented Jan 8, 2020

For those having this issue with linuxserver/nzbget you can modify the scripts shell settings via these instructions, which for me addressed the issue and now the nzbToMedia script runs successfully (without altering eol.py)
https://github.com/linuxserver/docker-nzbget#python-3-transition

That will work but will also force any other python extension scripts to use Python 3. If those other scripts are not Python 3 compatible, that will cause issues. I have to check VideoSort.py--that is the only other python extension script I use, and I'm not sure if it has been made Python 3 compliant.

@clinton-hall
Copy link
Owner

where did you get VideoSort.py from? I recall working on/contributing to this project back in the day, but can't recall where it ended up being hosted
It shouldn't be too difficult to make that project Python3 compatible.

@mannibis
Copy link

mannibis commented Jan 8, 2020

I believe I'm using this repo: https://github.com/nzbget/VideoSort

@clinton-hall
Copy link
Owner

yes, just found it... Hugbug has added a lot to this from the early discussions I recalled...

I'll see if I do find time to have a play and possibly submit a PR for python3 support....

@clinton-hall
Copy link
Owner

ok... I have updated a few things and got all of the imports to load etc....

https://github.com/clinton-hall/VideoSort

Feel free to give this a test and see if it functions... I'll share it with hugbug to see if he wants to merge.... but I'm not in a position to test it all.

clinton-hall referenced this issue in clinton-hall/VideoSort Jan 9, 2020
@ikkeenjij36
Copy link
Author

For me its solved with the work arounds and finally after updating so i will close it for now
Thanks for all the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests