Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last resort movie identification #1982

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

MattPark
Copy link
Contributor

@MattPark MattPark commented Oct 2, 2023

Description

I noticed that when imdb id is missing from movie folder filename, couchpotato often chokes. When nzbtomedia finds the IMDB id through a web search, we should append it to the folder name in the correct place before sending to couchpotato.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I made the changes and tested using a file that was missing imdb ID

Test Configuration:

Checklist:

  • I have based this change on the nightly branch
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

clinton-hall and others added 5 commits August 9, 2023 22:50
This parameter was not being loaded and therefore was ignored.
Return updated dir_name if needed
Check for an updated dir_name in case IMDB id was appended.
@clinton-hall clinton-hall changed the base branch from master to nightly December 15, 2023 20:21
@clinton-hall clinton-hall merged commit b802aca into clinton-hall:nightly Dec 15, 2023
5 of 7 checks passed
@clinton-hall
Copy link
Owner

Thanks for this. Sorry I missed this originally and only just saw it.
I have merged into nightly for now.

@clinton-hall clinton-hall mentioned this pull request Apr 25, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants