Initial support for extended CSS selectors (a.k.a. procedural filters) #1574
Conversation
This comment has been minimized.
This comment has been minimized.
remusao
force-pushed
the
procedural
branch
2 times, most recently
from
18a9400
to
6f47e2b
Compare
| expect(querySelectorAll(document.documentElement, ast)).to.have.members(expected); | ||
| } | ||
|
|
||
| describe('eval', () => { |
There was a problem hiding this comment.
a nit: using arrow functions with mocha is not recommended as some functionalities like this.timeout wont work
| parse( | ||
| 'table.tborder > tbody:has(:scope > tr > .alt1 > table > tbody > tr > td > a):has(strong):has(span > font > strong)', | ||
| ), | ||
| ).to.eql({ |
There was a problem hiding this comment.
putting expected value may improve the readability
| 'type': 'compound', | ||
| }); | ||
|
|
||
| expect(parse('.cls > a > div[class^="foo"]:has(button[class^="bar"])')).to.eql({ |
There was a problem hiding this comment.
Errors from those expectations may not be very helpful as those would just asset the objects are different while you are interested in the exact difference.
It may be worth to construct a smaller DOM to illustrate individual features in simpler "environment".
| // Normal CSS | ||
| if (styles && styles.length > 0) { | ||
| setTimeout(() => injectCSSRule(styles, window.document), 0); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
setTimeout 0 may be deferred by quite a bit. Consider using postMessage, requestAnimationFrame or Promise.resolve().then if you want to get the callback to fire asap.
On the other hand if a tick is needed it's always better to wait for a sideeffect before calling the "callback".
remusao
force-pushed
the
procedural
branch
2 times, most recently
from
1e735d1
to
ff0fc40
Compare
What Changed
:remove()modifier (:styleupdated to support procedural filters).:hasand:if:has-text:notRelease Notes
Add initial support for extended CSS selectors (a.k.a. procedural filters) as well as the
:remove()modifier for element hiding rules (note: the already supported:stylemodified now also works with extended CSS selectors). The following new pseudo-classes are implemented::has(and its alias:if),:has-text(both string and RegExp literals), and:not(whenever its argument is also an extended selector, otherwise fallback to native implementation).Caveats:
loadExtendedSelectorsoption while initializing the blocker instance.WebExtensionBlocker(support for Puppeteer, Electron and Playwright is not planned at this time but help from the community would be greatly appreciated).Miscellaneous changes:
injectCSSRulehelper.