fix regression, empty dict #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,14 +160,14 @@ class DictionaryCompiler | |||
| value_store_->CloseFeeding(); | |||
| sorter_.end(); | |||
| sorter_.merge_runs(); | |||
| CreateGenerator(); | |||
|
|
|||
| // check that at least 1 item is there | |||
| if (!sorter_.can_pull()) { | |||
There was a problem hiding this comment.
What about if we remove this check and add if ( sorter_.can_pull()) on line: 170 ?
|
LGTM |
hendrikmuhs
added a commit
to hendrikmuhs/keyvi
that referenced
this pull request
Jan 7, 2017
fix regression, empty dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression, creation of an empty dict segfaults. Also added missing test code for this.
@narek-cliqz