Some hints on to-string not being lazy #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingMob
requested changes
Jul 14, 2022
There was a problem hiding this comment.
Thanks for this! Couple changes before I can accept:
- The top-level
byte-streamsns has been deprecated, because in general, a top-level ns is not Java friendly, and in particular, it breaks attempts to use bs with Graal. Be sure to copy/move this to theclj-commons.byte-streams/to-stringfn - Let's change "Will consume all input." to "Will consume all the input it can." I don't see a test I can check for the behavior, but I'm pretty sure it will read all the bytes it can, and stop as soon as there's none available, even if more bytes come in later.
ieugen
added a commit
that referenced
this pull request
Jul 18, 2022
|
Created new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @KingMob on Slack https://clojurians.slack.com/archives/C0G922PCH/p1657694070527519?thread_ts=1657618678.781149&cid=C0G922PCH