Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to Clojure 1.3 and make the task run inside the project classpath. #5

Merged
merged 2 commits into from Nov 23, 2011

Conversation

budu
Copy link
Contributor

@budu budu commented Nov 14, 2011

see title...

@technomancy
Copy link
Contributor

Leiningen plugins actually shouldn't declare a dependency on Clojure itself; they get all the dependencies of Leiningen implicitly since they run in the same process.

@zk zk merged commit 03cfa7e into clj-commons:master Nov 23, 2011
@zk
Copy link
Collaborator

zk commented Nov 23, 2011

Also removed the clojure dep (dfac9b5).

Thanks guys.

@Raynes
Copy link

Raynes commented Nov 23, 2011

Note that running in the project means that the Clojure version that the project uses will be used. Given the current marginalia snapshot, lein marg will now fail in a 1.3.0 project. That's because marginalia.core is AOT compiled against 1.2 in that jar.

I committed a fix for that last night, making the only AOT'd stuff be main.clj. Just a heads up in case anybody runs into this problem with the current snapshot and can't figure it out. I recommend bugging fogus until he releases a new snapshot. ;)

@fogus
Copy link
Collaborator

fogus commented Nov 24, 2011

Just pushed a new 0.7.0-SNAPSHOT to clojars. :p

@Raynes
Copy link

Raynes commented Nov 24, 2011

Hooray! ;>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants