You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Symptom
When specifying a custom :auto-resolve fn on a zipper that also specifies :track-position? true, the custom auto-resolve function is not applied.
Diagnosis
The zipper options are intended to be stored as metadata on the zipper.
This is not-working/lost for :track-position? zippers.
Action
I shall dig in and follow up with a fix.
The text was updated successfully, but these errors were encountered:
lread
changed the title
Custom auto-resolve is not applied for :track-position zippers
Custom auto-resolve is not applied for :track-position? zippers
Jul 1, 2021
There is a bug in rewrite-clj v644 causing users to be unable to use
`:track-position` and `:auto-resolve` options at the same time in
rewrite zippers. See:
clj-commons/rewrite-clj#159
This makes, for example, building static code analysis tools with
babashka much harder. In fact when analysing code, the position is
relevant for the script output and resolving keywords and symbols might
be required for the analysis.
There is a bug in rewrite-clj v644 causing users to be unable to use
`:track-position` and `:auto-resolve` options at the same time in
rewrite zippers. See:
clj-commons/rewrite-clj#159
This makes, for example, building static code analysis tools with
babashka much harder. In fact when analysing code, the position is
relevant for the script output and resolving keywords and symbols might
be required for the analysis.
Version
1.0.644-alpha
Platform
all
Symptom
When specifying a custom
:auto-resolve
fn on a zipper that also specifies:track-position? true
, the custom auto-resolve function is not applied.Reproduction
Actual behavior
The default auto-resolve behaviour is applied.
;; => :?_current-ns_?/kw
Expected behavior
The custom auto-resolve fn should be applied and return:
;; => :testing123/kw
... as it does when
:track-position?
is not included in zipper options:Diagnosis
The zipper options are intended to be stored as metadata on the zipper.
This is not-working/lost for
:track-position?
zippers.Action
I shall dig in and follow up with a fix.
The text was updated successfully, but these errors were encountered: