-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid SARIF output #2345
Comments
nxvipin
added a commit
to nxvipin/clj-kondo
that referenced
this issue
Jun 28, 2024
- Fix the nesting level of `region` under the `results` property - Enhance SARIF output - Add Clj-kondo `version` to the SARIF output - Add `endLine` and `endColumn` to the linting results - Add `helpUri`, `level` and `enabled` to the linting rules
nxvipin
added a commit
to nxvipin/clj-kondo
that referenced
this issue
Jun 28, 2024
- Fix the nesting level of `region` under the `results` property - Enhance SARIF output - Add Clj-kondo `version` to the SARIF output - Add `endLine` and `endColumn` to the linting results - Add `helpUri`, `level` and `enabled` to the linting rules
nxvipin
added a commit
to nxvipin/clj-kondo
that referenced
this issue
Jun 28, 2024
- Fix the nesting level of `region` under the `results` property - Enhance SARIF output - Add Clj-kondo `version` to the SARIF output - Add `endLine` and `endColumn` to the linting results - Add `helpUri`, `level` and `enabled` to the linting rules
nxvipin
added a commit
to nxvipin/clj-kondo
that referenced
this issue
Jun 28, 2024
- Fix the nesting level of `region` under the `results` property - Enhance SARIF output - Add Clj-kondo `version` to the SARIF output - Add `endLine` and `endColumn` to the linting results - Add `helpUri`, `level` and `enabled` to the linting rules - Remove `artifacts` key as it did not contain any additonal data from what is available under the results key.
5 tasks
nxvipin
added a commit
to nxvipin/clj-kondo
that referenced
this issue
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version - 2024.05.24
Problem
The SARIF output generated by Clj-kondo does not conform to the schema specified here.
Specifically, the
region
attribute in theresults
location is nested at an incorrect level.According to the specification the correct nesting of
region
isresults -> locations -> physicalLocation -> region
Clj-kondo nests the
region
property underresults -> locations -> physicalLocation -> artifactLocation -> region
Repro
We have
bad_clojure.clj
:If we run
clj-kondo --lint bad_clojure.clj --config '{:output {:format :sarif}}'
we get this output -Output (Click to expand)
This output is invalid and can be validated here.
Expected behavior
The SARIF output would conform to the specification.
I can submit a PR that fixes this issue.
The text was updated successfully, but these errors were encountered: