Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trouble parsing defn forms in datascript #63

Closed
borkdude opened this issue Apr 8, 2019 · 2 comments
Closed

Trouble parsing defn forms in datascript #63

borkdude opened this issue Apr 8, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@borkdude
Copy link
Member

borkdude commented Apr 8, 2019

Not all defns forms in https://github.com/tonsky/datascript/blob/master/src/datascript/db.cljc can be parsed by clj-kondo.
@borkdude borkdude added the enhancement New feature or request label Apr 8, 2019
@borkdude borkdude mentioned this issue Apr 9, 2019
Closed
@borkdude
Copy link
Member Author

Repro:

(ns datascript.db
  (:refer-clojure :exclude [seqable?]))

(defn #?@(:clj  [^Boolean seqable?]
          :cljs [^boolean seqable?])
  [x] x)

(seqable? 1 2)

borkdude added a commit that referenced this issue Apr 20, 2019
@borkdude
Refactor CLJC processing
9ef7f0b 
See #67 and #63. 

- [x] be more intelligent about cljs macros (see #97) 
- [x] CLJC analyses split into clj and cljs
- [x] dedupe output
- [x] get rid of case false positives
- [x] refactored loading of namespaces
@borkdude
Copy link
Member Author

Fixed with 9ef7f0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borkdude