-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reflection warnings #221
Conversation
Adds type hints where indicated by compiler, and enable refection warnings in leiningen builds to help avoid future regressions.
Thanks for releasing #219. Unfortunately, master had introduced a new reflection warning since that pull request was made and so this library is still causing noise in our builds. Could you please consider this pull request that resolves two more warnings and enables reflection warnings for the project in general, so that future contributors will be reminded to add type hints? |
👍 I'll cut 0.12.2 with this in. |
Just so you're aware, with reflection warnings turned on for testing clj-time, it produces these warnings:
Which are all in Midje or its dependencies... |
Release 0.12.2 is on Clojars. |
Thanks. I only ran |
Adds type hints where indicated by compiler, and enable refection warnings in
leiningen builds to help avoid future regressions.