Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1009): Multi-column index selection for query macro #1012

Merged

Conversation

joshua-spacetime
Copy link
Collaborator

Looking up a positional FieldName in a Header was broken.

Description of Changes

Please describe your change, mention any related tickets, and so on here.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@joshua-spacetime joshua-spacetime changed the base branch from master to joshua/test/multi-col-index-selection March 21, 2024 20:01
@joshua-spacetime joshua-spacetime force-pushed the joshua/fix/1009/query-macro-multi-col-index branch from 19bc387 to a5c4985 Compare March 21, 2024 20:02
@joshua-spacetime joshua-spacetime force-pushed the joshua/test/multi-col-index-selection branch from 5455430 to 9982dcf Compare March 21, 2024 20:38
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the above change (how my PR #939 was originally).

Fixes #1009.

Looking up a positional FieldName in a Header was broken.
@joshua-spacetime joshua-spacetime force-pushed the joshua/fix/1009/query-macro-multi-col-index branch from a5c4985 to be52a87 Compare March 21, 2024 22:35
@joshua-spacetime joshua-spacetime changed the base branch from joshua/test/multi-col-index-selection to master March 21, 2024 22:35
@joshua-spacetime joshua-spacetime linked an issue Mar 21, 2024 that may be closed by this pull request
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Mar 21, 2024
Merged via the queue into master with commit fb932b6 Mar 21, 2024
6 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/fix/1009/query-macro-multi-col-index branch March 21, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query macro does not select multi-column indexes
2 participants