test: Multi-column index selection through query macro #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
reviewed
Mar 21, 2024
joshua-spacetime
force-pushed
the
joshua/test/multi-col-index-selection
branch
3 times, most recently
from
871de66
to
5455430
Compare
| @@ -234,8 +237,6 @@ impl PointerMap { | |||
| /// | |||
| /// Handles any hash conflicts for `hash`. | |||
| pub fn insert(&mut self, hash: RowHash, ptr: RowPointer) -> bool { | |||
| debug_assert!(self.maintains_invariants()); | |||
There was a problem hiding this comment.
I'm not sure why these were left in, but they make populating a table quadratic time.
There was a problem hiding this comment.
Were these a problem in terms of the runtime of tests? Otherwise, these are in the debug profile only and are used to test an invariant that unsafe code assumes.
| let json = r#"{"call": {"fn": "test_index_scan_on_chunk", "args": []}}"#; | ||
| module.send(json.to_string()).await.unwrap(); | ||
|
|
||
| let json = r#"{"call": {"fn": "test_index_scan_on_x_z_dimension", "args": []}}"#; |
There was a problem hiding this comment.
This test will not pass without #1012
joshua-spacetime
force-pushed
the
joshua/test/multi-col-index-selection
branch
from
5455430
to
9982dcf
Compare
joshua-spacetime
force-pushed
the
joshua/test/multi-col-index-selection
branch
from
9982dcf
to
18f7b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!