Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: format C# module SDK code #1149

Merged
merged 1 commit into from
Apr 25, 2024
Merged

NFC: format C# module SDK code #1149

merged 1 commit into from
Apr 25, 2024

Conversation

RReverser
Copy link
Member

Description of Changes

While looking through the large diffs while splitting out small PRs out of my refactor branch, I noticed that quite a lot of noise is from me working on a formatted code and using primary constructors while the one in master is not.

As such, I'm splitting out just those automated / non-functional changes into a separate PR to make subsequent functional diffs easier to read.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

1

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Checked that it still builds.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied. All the changes here are automated via CSharpier + IDE, so checking that it builds is enough.

While looking through the large diffs while splitting out small PRs out of my refactor branch, I noticed that quite a lot of noise is from me working on a formatted code and using primary constructors while the one in master is not.

As such, I'm splitting out just those automated / non-functional changes into a separate PR to make subsequent functional diffs easier to read.
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RReverser RReverser added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit cdf4620 Apr 25, 2024
6 checks passed
@RReverser RReverser deleted the format-csharp branch April 25, 2024 00:38
RReverser added a commit that referenced this pull request Apr 29, 2024
For some reason these automated refactoring conversions didn't get included in #1149.
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2024
* NFC: few more C# shorthand conversions

For some reason these automated refactoring conversions didn't get included in #1149.

* Also remove unused usings

* Restore a using that was erroneously marked as unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants