Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR status check that fails unless based on master #1180

Merged
merged 5 commits into from
May 1, 2024
Merged

Add PR status check that fails unless based on master #1180

merged 5 commits into from
May 1, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Apr 29, 2024 •
edited
Loading

Description of Changes

CI change - block PRs from merging if not based on master

API and ABI breaking changes

No

Testing

In a test repo:

@bfops bfops added Do not merge Do not merge PRs with this label without coordinating further and removed Do not merge Do not merge PRs with this label without coordinating further labels Apr 29, 2024
@bfops bfops marked this pull request as ready for review April 29, 2024 20:19
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Apr 29, 2024
@bfops bfops changed the title Block PRs from merging unless based on master Add PR status check that fails unless based on master May 1, 2024
cloutiertyler
cloutiertyler approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea.

@bfops bfops removed the request for review from jdetter May 1, 2024 17:33
@bfops bfops added this pull request to the merge queue May 1, 2024
Merged via the queue into master with commit 6810821 May 1, 2024
10 checks passed
@bfops bfops mentioned this pull request May 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
@bfops
Fix #1180: Add PR status check that fails unless based on master (#1213)
669d487 
* [bfops/fix-github-action]: fix?

* [bfops/fix-github-action]: empty

---------

Co-authored-by: Zeke Foppa <github.com/bfops>
@bfops bfops deleted the bfops/block-pr-chain branch September 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

Assignees
No one assigned
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfops @cloutiertyler