Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS for LICENSE.txt #1225

Merged
merged 2 commits into from
May 14, 2024
Merged

Add CODEOWNERS for LICENSE.txt #1225

merged 2 commits into from
May 14, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented May 14, 2024 •
edited
Loading

Description of Changes

Adds a CODEOWNERS entry for all LICENSE.txt files.

This also makes sure that @cloutiertyler signs off on any version bumps, which update the root LICENSE.txt.

This means that @cloutiertyler is the signoff on every release.

API and ABI breaking changes

No.

Expected complexity level and risk

0

Testing

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels May 14, 2024
@bfops bfops requested a review from cloutiertyler May 14, 2024 04:46
@bfops bfops changed the title Add CODEOWNERS for LICENSE.txt Add CODEOWNERS for non-runtime files May 14, 2024
@bfops bfops changed the title Add CODEOWNERS for non-runtime files Add CODEOWNERS for LICENSE.txt May 14, 2024
jdetter
jdetter approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good protection 👍

cloutiertyler
cloutiertyler approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit 7d41e76 May 14, 2024
18 checks passed
@bfops bfops deleted the bfops/codeowners branch May 14, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdetter jdetter jdetter approved these changes

@cloutiertyler cloutiertyler cloutiertyler approved these changes

Assignees
No one assigned
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfops @jdetter @cloutiertyler