Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consistent filtering rules for C# modules #1282

Merged
merged 1 commit into from
May 28, 2024

Conversation

RReverser
Copy link
Member

Description of Changes

Implements consistent filtering rules proposal (#1256) for C# modules.

API and ABI breaking changes

Limits types that FilterBy functions are generated on, as well as types that Unique constraint can be applied on, to those in the proposal.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@RReverser RReverser added the api-break A PR that breaks some user-visible API label May 22, 2024
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RReverser RReverser added the breaks library compatibility This change breaks the SpacetimeDB library interface label May 28, 2024
@RReverser RReverser force-pushed the ingvar/consistent-filtering-csharp-server branch from 79fdd08 to d5836ef Compare May 28, 2024 13:46
@RReverser RReverser added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit a7c7575 May 28, 2024
6 checks passed
@RReverser RReverser deleted the ingvar/consistent-filtering-csharp-server branch May 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that breaks some user-visible API breaks library compatibility This change breaks the SpacetimeDB library interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants