Create new crate fs-utils; move Lockfile and create_parent_dir
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snapshot crate will need to create lockfiles. Rather than duplicating code to do so, we choose to move our definition of `Lockfile` into a crate that can be depended on by both `cli` and `snapshot`. No existing crate seems like an obvious choice for this -- a `Lockfile` is not really a data structure, so `data-structures` seems wrong -- so we add a new crate, `fs-utils`. Currently this contains only `Lockfile` and `create_parent_dir`, but a follow-up PR will add `DirTrie`, a Git-like on-disk object store.
Centril
approved these changes
Jun 4, 2024
bfops
reviewed
Jun 4, 2024
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Phoebe Goldman <phoebe@goldman-tribe.org>
bfops
approved these changes
Jun 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The snapshot crate will need to create lockfiles. Rather than duplicating code to do so, we choose to move our definition of
Lockfileinto a crate that can be depended on by bothcliandsnapshot. No existing crate seems like an obvious choice for this -- aLockfileis not really a data structure, sodata-structuresseems wrong -- so we add a new crate,fs-utils. Currently this contains onlyLockfileandcreate_parent_dir, but a follow-up PR will addDirTrie, a Git-like on-disk object store.API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!