-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the snapshot
crate, which implements snapshotting at a low level
#1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requires making `BlobHash` be `Serialize` and `Deserialize`. For arcane macro-ology reasons, this requires writing `BlobHash::SIZE` instead of `Self::SIZE` (it gets embedded in a visitor struct or something). - Requires adding two new operators to `BlobStore`. - Adds a return value to `Page::save_content_hash`, for convenience. - Impls `DerefMut` for `Pages`. - **Scary change:** adds `Table::pages_mut`. I think possibly this operator should be `unsafe`, since write access to the `Pages` allows an undisciplined caller to violate the `Table`'s assumptions by corrupting a `Page`. It seems like an anti-pattern to mark a method `unsafe` on the grounds that misusing its return value can cause UB, but I don't see a plausible alternative without making most methods on `Page` unsafe. Open to feedback on this one!
As an alternative to |
Centril
reviewed
Jun 5, 2024
Centril
reviewed
Jun 5, 2024
Centril
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
BlobHash
beSerialize
andDeserialize
. For arcane macro-ology reasons, this requires writingBlobHash::SIZE
instead ofSelf::SIZE
(it gets embedded in a visitor struct or something).BlobStore
.Page::save_content_hash
, for convenience.DerefMut
forPages
.Scary change: addsTable::pages_mut
. I think possibly this operator should beunsafe
, since write access to thePages
allows an undisciplined caller to violate theTable
's assumptions by corrupting aPage
. It seems like an anti-pattern to mark a methodunsafe
on the grounds that misusing its return value can cause UB, but I don't see a plausible alternative without making most methods onPage
unsafe. Open to feedback on this one!Table::iter_pages_with_hashes
, which iterates over all pages, ensuring their hashes are present before yielding.API and ABI breaking changes
N/a
Expected complexity level and risk
3 - see above comment re: safety of
Table::pages_mut
.Testing
Tested manually in #1279 . Not convinced there's a useful way write tests for this in isolation i.e. before integrating.