durability: Skip fsync if nothing changed #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
changed the title
kim
force-pushed
the
kim/durability/skip-fsync-noop
branch
2 times, most recently
from
387a389
to
f2903ac
Compare
Centril
reviewed
Jun 10, 2024
Make the local durability impl compare offsets and skip flush / fsync if nothing changed.
kim
force-pushed
the
kim/durability/skip-fsync-noop
branch
from
f2903ac
to
2d83784
Compare
gefjon
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the local durability impl compare offsets and skip flush / fsync if
nothing changed.
Expected complexity level and risk
1