Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

durability: Skip fsync if nothing changed #1360

Merged
merged 1 commit into from
Jun 11, 2024
Merged

durability: Skip fsync if nothing changed #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/durability/src/imp/local.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ impl<T: Send + Sync + 'static> FlushAndSyncTask<T> {

loop {
interval.tick().await;

// Skip if nothing changed.
if let Some(committed) = self.clog.max_committed_offset() {
let durable = self.offset.load(Acquire);
if durable.is_positive() && committed == durable as _ {
continue;
}
}

let clog = self.clog.clone();
let task = spawn_blocking(move || clog.flush_and_sync()).await;
match task {
Expand Down
Loading