[NFC] [C#] Minor simplifications to type checks in Roslyn codegen #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
reviewed
Jun 12, 2024
| // while something like `string?` is expanded to `string` with the nullable annotation set to `Annotated`... | ||
| // Beautiful design requires beautiful hacks. | ||
| if ( | ||
| type.NullableAnnotation == NullableAnnotation.Annotated | ||
| && type.OriginalDefinition.ToString() != "System.Nullable<T>" | ||
| && type.OriginalDefinition.SpecialType != SpecialType.System_Nullable_T |
There was a problem hiding this comment.
Hey, at least you got rid of the string comparison 👍
There was a problem hiding this comment.
Heh yeah. Too bad List, Dictionary and the rest are not "special" types as well.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Minor simplifications to type checks in Roslyn codegen.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
dotnet test