Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] [NFC] Use semantic model's type where possible #1401

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

RReverser
Copy link
Member

Description of Changes

This fixes issues with nullability annotations (see the removed TODO), inconsistent field selection between [SpacetimeDB.Type] and [SpacetimeDB.Table], as well as should be more efficient overall as it gets the type model for the structure in one go instead of individually for each field.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • dotnet test
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

This fixes issues with nullability annotations, inconsistent field selection between `[SpacetimeDB.Type]` and `[SpacetimeDB.Table]`, as well as should be more efficient overall as it gets type model in one go instead of individually for each field.
@RReverser RReverser added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit 2b7b19e Jun 12, 2024
8 checks passed
@RReverser RReverser deleted the ingvar/csharp-semantic-model branch June 13, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants