TableDef: clarify generated_* methods
#1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
To improve my understanding of what
TableDefandTableSchemaactually do wrt. indices & constraints, I slightly refactored theTableDef::generated_*methods and added commentary. This should make it easier to understand the implementation of the index hack I am working on.One semantic aspect that changed here is that I removed the binary searches -- they don't seem to be correct, as I did not determine that we actually keep a sorted order by name in a
TableDef.This patch is likely to become obsolete once the new schema impl is written, but I found it helpful in the interim.
API and ABI breaking changes
None
Expected complexity level and risk
1