Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MacOS builds from CI are executable #1462

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kurtismullins
Copy link
Collaborator

Description of Changes

The spacetime binary in the MacOS build's tarball is not flagged as executable.

This makes it executable.

API and ABI breaking changes

n/a

Expected complexity level and risk

It only affects future release automation. I assume there is next to no risk.

Testing

Untested as this specific CI is only ran on master, release branches, and tags.

Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to argue with that!

@kurtismullins kurtismullins added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 2399e74 Jun 26, 2024
8 checks passed
@kurtismullins kurtismullins deleted the kurtis/ensure-macos-build-is-executable branch July 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants