C# smoketests use nuget.config
#1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
added 12 commits
July 12, 2024 11:18
jdetter
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
I would ask @RReverser to take another look at this when he gets back, but for now this is fine with me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Our C# smoketests used to manually modify the
.csprojfile generated byspacetime init --lang csharp.This PR modifies the smoketests to not modify the
.csproj, and to instead add a separatenuget.configfile. This is easier to maintain / less prone to breakage. (It was also partly just practice of usingnuget.config, because it's easier to port it over to other scenarios)This seems to have resolved the issue where pointing to
0.10.0might still pull from NuGet instead of the local repo. I'm not 100% sure that it's actually due to this change - I may have tested that issue incorrectly before (I may have pointed at0.10.*and updated the local package version to0.10.0, and it might have decided to pull0.10.1from NuGet because it was more recent; not completely sure)API and ABI breaking changes
Nope.
Expected complexity level and risk
1
Testing