Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some helper scripts #1501

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Add some helper scripts #1501

merged 3 commits into from
Jul 18, 2024

Conversation

kazimuth
Copy link
Contributor

Description of Changes

I keep forgetting the right invocations to run all the tests & clippy correctly, so I added some scripts that do this.

Expected complexity level and risk

0

Testing

I ran the scripts :)

@kazimuth kazimuth requested a review from bfops July 12, 2024 21:20
@bfops bfops added the release-any To be landed in any release window label Jul 15, 2024
tools/clippy.sh Outdated Show resolved Hide resolved
tools/run-all-tests.sh Outdated Show resolved Hide resolved
tools/run-all-tests.sh Outdated Show resolved Hide resolved
tools/run-all-tests.sh Outdated Show resolved Hide resolved

cd "$stdb_root"

tools/clippy.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires tools/clippy.sh to be executable. I pushed a commit to make both of these executable (so we can run them both directly rather than e.g. bash tools/clippy.sh)

Copy link
Contributor Author

@kazimuth kazimuth Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. For some reason my git executable kept ignoring when I did that, no idea why. Maybe a WSL thing...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was wondering if you were on Windows in some form. I think it comes down to the fact that Windows doesn't have the same filesystem bits for controlling permissions. There's some other way to manually force the changes into git..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is how to write it directly into the git index:

git update-index --chmod=+x <file>

https://stackoverflow.com/questions/6476513/git-file-permissions-on-windows

Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

This will be nicer than me always doing Ctrl-R clippy.

@kazimuth kazimuth added this pull request to the merge queue Jul 18, 2024
Merged via the queue into master with commit 0ed26a7 Jul 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants