-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some helper scripts #1501
Add some helper scripts #1501
Conversation
0614547
to
cf0db09
Compare
|
||
cd "$stdb_root" | ||
|
||
tools/clippy.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires tools/clippy.sh
to be executable. I pushed a commit to make both of these executable (so we can run them both directly rather than e.g. bash tools/clippy.sh
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. For some reason my git executable kept ignoring when I did that, no idea why. Maybe a WSL thing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was wondering if you were on Windows in some form. I think it comes down to the fact that Windows doesn't have the same filesystem bits for controlling permissions. There's some other way to manually force the changes into git..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is how to write it directly into the git index:
git update-index --chmod=+x <file>
https://stackoverflow.com/questions/6476513/git-file-permissions-on-windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
This will be nicer than me always doing Ctrl-R clippy
.
Description of Changes
I keep forgetting the right invocations to run all the tests & clippy correctly, so I added some scripts that do this.
Expected complexity level and risk
0
Testing
I ran the scripts :)