Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to add jar to index causes the user to be notified that the deploy failed #568

Closed
tobias opened this issue Sep 26, 2016 · 0 comments
Closed

Failure to add jar to index causes the user to be notified that the deploy failed #568

tobias opened this issue Sep 26, 2016 · 0 comments

Comments

@tobias
Copy link
Member

tobias commented Sep 26, 2016

When in fact the deploy succeeded except for indexing. This can happen if the index file is locked (which will happen if we are regenerating the index).

It may be more appropriate to not allow an indexing failure to bubble out to the user, but instead just notify the admins.
@tobias tobias changed the title Failure add jar to index indicates to the user that the deploy failed Failure to add jar to index causes the user to be notified that the deploy failed Oct 1, 2016
tobias added a commit that referenced this issue Feb 10, 2020
@tobias
Index deployed jar asynchronously
42470d4 
Some users see timeouts when deploying, so we should do less before
returning to the user. One thing we can do is index the jar in another
thread. This will also prevent indexing failures from being reported
to the user, making them think the deploy failed (see #568).
@tobias tobias closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobias