-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use nrepl, not eval #14
Conversation
stub-in is-complete-reply nrepl instead of eval
Conflicts: src/ipython_clojure/core.clj
Apparently I still don't quite understand how squashing commits works. Thus the 3 commits...Sorry. |
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
Thank you so so so so so so so much, Peter. This is incredible. I am so happy, it would have taken me forever to figure that out. I gave you push access to the repository, as far as I am concerned you should own it. |
Well thanks for all the work on Zero MQ and the interface with the the On 2016-02-18 9:58 PM, Rory Kirchner wrote:
|
Sweet, I have been walking around happy today. These bugs were weighing on me and I didn't realize it. Thanks so much! |
@pdenno , it seems this PR actually broke something basic: you can no longer print to stdout. I.e. something like I think the reason is that stdout used to be captured by the In the world of |
As the subject suggests, this is a major change. Writing a reliable REPL, which is where this code seemed to be heading, is a lot of work. tools.nrepl is a REPL solution made just for this sort of problem, and it is tested (used by emacs/cider etc.) and solid. See the section why nREPL? at tools.nrepl github.
I have not experienced any problems changing namespaces in this fork. I implemented stacktraces using code from cider-nrepl.