Build clojure expressions as elisp sexps, then print them compatibly to strings #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @samaaron, I thought you might find this interesting.
Those strings full of clojure inside ac-nrepl bugged me, so I started wondering if we could just send sexps. Turns out that it's possible; you just have to avoid some Clojure reader syntaxes (like "#{}") which are incompatible with Elisp's reader.
This trick makes assembling the sexps much easier, because they can just be
backquote
d together rather than relying on "format".The downside was that it required some custom printing trickery to work around the fact that Elisp normally
print
s symbols likeclojure.core/map
asclojure\.core/map
. A further minor downside is that the elisp indentation doesn't understand Clojure's indentation rules.I'd be interested to hear what you think.
-Steve