test-var-query does not run tests with + in the name

[bpringe]

Expected behavior

Tests with + in the name are run successfully.

Actual behavior

Tests with + in the name are not run successfully.

Steps to reproduce the problem

Please see this Calva issue here for details: BetterThanTomorrow/calva#1383.

It seems that if a + is in the middle of the test name, the test isn't found. If the + is at the beginning of the test name, an exception is thrown in the repl.

In Calva, we send the test as below, and I verified that test has the appropriate test name - that it was not altered by Calva before being send to cider-nrepl.

            this.client.write({
                op: "test-var-query",
                ns,
                id,
                session: this.sessionId,
                "var-query": {
                    "ns-query": {
                        exactly: [ns]
                    },
                    search: test,
                    "search-property": "name"
                }
            });

Environment & Version information

cider-nrepl version

0.26.0

Java version

openjdk 16.0.2 2021-07-20
OpenJDK Runtime Environment Temurin-16.0.2+7 (build 16.0.2+7)
OpenJDK 64-Bit Server VM Temurin-16.0.2+7 (build 16.0.2+7, mixed mode, sharing)

Operating system

MacOS Monterey

[bbatsov]

My guess is that + is messing up the var-query, but I'll have to test it explicitly. The old more specific test ops were deprecated in favor of test-var-query, as it provides all of their functionality and more.

[vemv]

I've tested orchard.query/vars which is what test-var-query uses and it appears to work just fine:

If you pass a + it should be escaped (presumably client-side: we shouldn't second-guess what a client meant). Pattern/quote can be useful, for example.

Does that make sense, @bpringe ?

[bpringe]

Ah, yes that does make sense. Thanks! I'll close this, then.