Test runner not finding tests with + in middle of the name

[rjerue]

Given the following file:

(ns app.fun-test
  (:require [clojure.test :refer [deftest is]]))

(deftest name-with+in-it
  (is true))

(deftest name-with-plus-end+
  (is true))

(deftest name-with-plus-in-it
  (is true))

(deftest +name-with-plus-start
  (is true))

this is the output

; Evaluating file: fun_test.clj
#'app.fun-test/name-with-plus-in-it
; Running test: name-with+in-it…
; No tests found. 😱, ns: 0, vars: 0
clj꞉app.fun-test꞉> 
; Evaluating file: fun_test.clj
#'app.fun-test/name-with-plus-in-it
; Running test: name-with-plus-end+…
; 1 tests finished, all passing 👍, ns: 1, vars: 1
clj꞉app.fun-test꞉> 
; Evaluating file: fun_test.clj
#'app.fun-test/name-with-plus-in-it
; Running test: name-with-plus-in-it…
; 1 tests finished, all passing 👍, ns: 1, vars: 1
clj꞉app.fun-test꞉> 
; Evaluating file: fun_test.clj
#'app.fun-test/+name-with-plus-start
; Running test: +name-with-plus-start…

Note, the last one hangs with the following error in the console:

Exception in thread "nREPL-session-f877bb99-3510-4125-81e9-6647caa1a1dd" 
java.util.regex.PatternSyntaxException: Dangling meta character '+' near index 0
+name-with-plus-end

The last error + regex escaping fun a coworker had while searching for the test lead me to believe that there's a regex escaping issue somewhere with the + character.

Expected behavior is that these tests would be detected with the Run Current Test command.

[bpringe]

Thanks for reporting! We should see if this might be an issue with nrepl/cider-nrepl. Calva pretty much just uses cider-nrepl to run the tests - see here: https://github.com/BetterThanTomorrow/calva/blob/published/src/testRunner.ts.

Do you have the same / similar issues when running the command to run all tests and the command to run all tests for the namespace?

[bpringe]

@bbatsov Have you seen something like this before?

[rjerue]

Using the same file as above, if I use the run all tests or run all tests in current namespace, things seem to work fine. It's only the individual "run current test" where things break.

[bbatsov]

@bpringe I haven't seen this problem, but it's likely on cider-nrepl's side. Feel free to file a ticket there, so we don't forget to look into this. I guess it should be an easy fix.

[bpringe]

It seems we can/should fix this issue in Calva. Details are here: clojure-emacs/cider-nrepl#730 (comment).

If you pass a + it should be escaped (presumably client-side: we shouldn't second-guess what a client meant).

[marcomorain]

I might take a look at this this week.

[marcomorain]

I've opened a PR that addresses this.