Add extra-metadata options to complete middleware #195
Conversation
Deraen
force-pushed
the
arglists-and-doc
branch
from
64832f9
to
1669e34
Compare
|
This looks good to me, thanks for tackling the CLJS side of this as well! |
| @@ -57,7 +60,8 @@ | |||
| :requires {"symbol" "The symbol to lookup" | |||
| "ns" "The symbol's namespace" | |||
| "session" "The current session"} | |||
| :optional {"context" "Completion context for compliment."} | |||
| :optional {"context" "Completion context for compliment." | |||
| "extra-metadata" "List of extra-metadata fields"} | |||
There was a problem hiding this comment.
Maybe we should document the possible values extra-metadata can contain here too. AFAICT it's just :arglists and :doc for now?
Deraen
force-pushed
the
arglists-and-doc
branch
from
1669e34
to
6f787b0
Compare
|
Both PRs are merged. @alexander-yakushev I think we need a new compliment release/snapshot? |
|
@Deraen This could use a few specs. |
|
And by specs he means tests. On Tue, Apr 28, 2015, 08:39 Bozhidar Batsov notifications@github.com
|
|
Sure. I see there are tests for cljs complete I can extend but there seems to be no tests for clj complete yet? I'll update the PR in the evening. |
Hmm, thought we had some - if we don't guess you can use the cljs tests as a starting point. |
Deraen
force-pushed
the
arglists-and-doc
branch
3 times, most recently
from
10fea7f
to
a0a50d4
Compare
|
Some tests are failing, although the errors are pretty confusing to me. I've restarted the build. Btw, our conventions mandate the use of present simple tense for commit message titles. |
|
Some tests are failing as cljs-tooling needs a fix to work with cljs-3196. And looks like some tests are failing because travis problems (Problem opening jar). |
|
Seen that one before, restarting the tests worked for me. On Fri, May 1, 2015, 09:43 Juho Teperi notifications@github.com wrote:
|
|
I've restarted this build twice now, but it keeps failing with the same problems. |
|
@cichli You're our resident ClojureScript expert. What's your advise regarding cljs-3196? |
|
Sorry for the delayed reply, totally missed this notification... the Travis caching problems are gone now. As @Deraen says, we just need gtrak/cljs-tooling#19 to be resolved and a new cljs-tooling release to be cut to fix the failing tests. |
|
I reworded commit messages. Cljs-tooling change is hopefully now ok and is just waiting for @gtrak to check it. |
The option allows frontends to request arglists and docstring metadata for each completion results. The option is passed to Compliment and Cljs-tooling.
Deraen
changed the title
|
Updated with new cljs-tooling dep and everything should be working now. |
Deraen
changed the title
Deraen
changed the title
Add extra-metadata options to complete middleware
|
👍 |
Fixes #176
Merged: alexander-yakushev/compliment#26
Merged: gtrak/cljs-tooling/pull/18
Merged: gtrak/cljs-tooling/pull/19
@bbatsov In relation to alexander-yakushev/compliment#26
I decided to open this PR here for comments even though PR to Compliment is not merged yet and cljs-tooling doesn't have the support for options yet.
Added options which allow frontends to request arglists and doc for each completion results. Passes the options to Compliment.