-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return cider-test result keys more specifically #282
Conversation
* Override `clojure.test` implementation of `test-var` to differentiate between errors occurring in assertions and test faults that do not. * Set the same fault flag on errors occurring in test fixtures. * Update the `report` function to return only keys that properly describe the test event: Failed tests return `actual`; errors return `error`. Test assertions have and `expected` value; non-assertion faults do not.
@benedekfazekas Seems that the new mranderson doesn't work with Java 6, right? |
It should work with a workaround, see our discussion here #247 |
Yeah, I remembered this. Guess it's not important at all, as at the end of the day I create the jars under JDK8. |
Probably this should be backported as well 6b7fcb8 |
Add source file path, relative path, line and column number to compiler errors. Trim the message to a simple description.
Return cider-test result keys more specifically
Hmm, I've got one failing test in the branch:
However, I cut the release, as I didn't have time to investigate - hopefully it's nothing major. |
Damn, just looked at the build - everything is failing. |
I opened a PR with that commit on the v0.10 branch: #283 |
This brings in commit a62f937 to be compatible with a bug fix going into cider 0.10.1.