Return cider-test result keys more specifically #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Override `clojure.test` implementation of `test-var` to differentiate between errors occurring in assertions and test faults that do not. * Set the same fault flag on errors occurring in test fixtures. * Update the `report` function to return only keys that properly describe the test event: Failed tests return `actual`; errors return `error`. Test assertions have and `expected` value; non-assertion faults do not.
|
@benedekfazekas Seems that the new mranderson doesn't work with Java 6, right? |
|
It should work with a workaround, see our discussion here #247 |
|
Yeah, I remembered this. Guess it's not important at all, as at the end of the day I create the jars under JDK8. |
|
Probably this should be backported as well 6b7fcb8 |
Add source file path, relative path, line and column number to compiler errors. Trim the message to a simple description.
bbatsov
added a commit
that referenced
this pull request
Jan 5, 2016
Return cider-test result keys more specifically
|
Hmm, I've got one failing test in the branch: However, I cut the release, as I didn't have time to investigate - hopefully it's nothing major. |
|
Damn, just looked at the build - everything is failing. |
|
I opened a PR with that commit on the v0.10 branch: #283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in commit a62f937 to be compatible with a bug fix going into cider 0.10.1.